Skip to content

Commit d005cde

Browse files
committed
Address review
1 parent 72ddb66 commit d005cde

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

llvm/lib/Transforms/Vectorize/LoopVectorize.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7608,7 +7608,7 @@ static bool planContainsAdditionalSimplifications(VPlan &Plan,
76087608
}
76097609
// The VPlan-based cost model is more accurate for partial reduction and
76107610
// comparing against the legacy cost isn't desirable.
7611-
if (dyn_cast<VPPartialReductionRecipe>(&R))
7611+
if (isa<VPPartialReductionRecipe>(&R))
76127612
return true;
76137613
if (Instruction *UI = GetInstructionForCost(&R))
76147614
SeenInstrs.insert(UI);

llvm/lib/Transforms/Vectorize/VPlan.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2447,6 +2447,7 @@ class VPPartialReductionRecipe : public VPSingleDefRecipe {
24472447
"Unexpected operand order for partial reduction recipe");
24482448
}
24492449
~VPPartialReductionRecipe() override = default;
2450+
24502451
VPPartialReductionRecipe *clone() override {
24512452
return new VPPartialReductionRecipe(Opcode, getOperand(0), getOperand(1));
24522453
}

llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ void VPPartialReductionRecipe::execute(VPTransformState &State) {
337337

338338
CallInst *V = Builder.CreateIntrinsic(
339339
RetTy, Intrinsic::experimental_vector_partial_reduce_add,
340-
{PhiVal, BinOpVal}, nullptr, Twine("partial.reduce"));
340+
{PhiVal, BinOpVal}, nullptr, "partial.reduce");
341341

342342
State.set(this, V);
343343
}

0 commit comments

Comments
 (0)