Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit d52eb9b

Browse files
committedJun 18, 2025·
[fixup] Remove "SMMLA" from some names
... since we generate now all of smmla/ummla/usmmla.
1 parent 8f97d89 commit d52eb9b

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed
 

‎mlir/include/mlir/Dialect/ArmNeon/Transforms.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace mlir {
1313
class RewritePatternSet;
1414

1515
namespace arm_neon {
16-
void populateLowerContractionToSMMLAPatternPatterns(
16+
void populateLowerContractionToNeonI8MMPatternPatterns(
1717
RewritePatternSet &patterns);
1818
} // namespace arm_neon
1919

‎mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVMPass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ void ConvertVectorToLLVMPass::runOnOperation() {
8585
populateVectorGatherLoweringPatterns(patterns);
8686
if (armI8MM) {
8787
if (armNeon)
88-
arm_neon::populateLowerContractionToSMMLAPatternPatterns(patterns);
88+
arm_neon::populateLowerContractionToNeonI8MMPatternPatterns(patterns);
8989
if (armSVE)
9090
populateLowerContractionToSVEI8MMPatternPatterns(patterns);
9191
}

‎mlir/lib/Dialect/ArmNeon/TransformOps/ArmNeonVectorTransformOps.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ using namespace mlir;
2020

2121
void transform::ApplyArmNeonContractionToI8MMPatternsOp::populatePatterns(
2222
RewritePatternSet &patterns) {
23-
arm_neon::populateLowerContractionToSMMLAPatternPatterns(patterns);
23+
arm_neon::populateLowerContractionToNeonI8MMPatternPatterns(patterns);
2424
}
2525

2626
//===----------------------------------------------------------------------===//

‎mlir/lib/Dialect/ArmNeon/Transforms/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
add_mlir_dialect_library(MLIRArmNeonTransforms
2-
LowerContractionToSMMLAPattern.cpp
2+
LowerContractionToNeonI8MMPattern.cpp
33

44
DEPENDS
55
MLIRArmNeonIncGen

‎mlir/lib/Dialect/ArmNeon/Transforms/LowerContractionToSMMLAPattern.cpp renamed to ‎mlir/lib/Dialect/ArmNeon/Transforms/LowerContractionToNeonI8MMPattern.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
//===- LowerContractionToSMMLAPattern.cpp - Contract to SMMLA ---*- C++ -*-===//
1+
//===- LowerContractionToNeonI8MMPattern.cpp - Contract to I8MM -*- C++ -*-===//
22
//
33
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
44
// See https://llvm.org/LICENSE.txt for license information.
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
88
//
9-
// This file implements lowering patterns from vector.contract to
10-
// arm_neon.intr.smmla
9+
// This file implements lowering patterns from vector.contract to operations
10+
// that map to instructions from the Neon FEAT_I8MM extension.
1111
//
1212
//===---
1313

@@ -117,7 +117,7 @@ Value createMMLA(PatternRewriter &rewriter, MMLA op, Location loc,
117117
/// as [2,2,8] is a divisor of its shape. It can also process vecmats with dimM
118118
/// = 1 (either explicitly or inferred if LHS has only dimK) If no unrolling is
119119
/// necessary, a single smmla instruction is emitted.
120-
class LowerContractionToSMMLAPattern
120+
class LowerContractionToNeonI8MMPattern
121121
: public OpRewritePattern<vector::ContractionOp> {
122122
public:
123123
using OpRewritePattern::OpRewritePattern;
@@ -352,8 +352,8 @@ class LowerContractionToSMMLAPattern
352352

353353
} // namespace
354354

355-
void mlir::arm_neon::populateLowerContractionToSMMLAPatternPatterns(
355+
void mlir::arm_neon::populateLowerContractionToNeonI8MMPatternPatterns(
356356
RewritePatternSet &patterns) {
357357
MLIRContext *context = patterns.getContext();
358-
patterns.add<LowerContractionToSMMLAPattern>(context, /*benefit=*/2);
358+
patterns.add<LowerContractionToNeonI8MMPattern>(context, /*benefit=*/2);
359359
}

‎mlir/lib/Dialect/ArmSVE/Transforms/LowerContractionToSVEI8MMPattern.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//===- LowerContractionToSMMLAPattern.cpp - Contract to SMMLA ---*- C++ -*-===//
1+
//===- LowerContractionToSVEI8MMPattern.cpp - Contract to I8MM --*- C++ -*-===//
22
//
33
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
44
// See https://llvm.org/LICENSE.txt for license information.

0 commit comments

Comments
 (0)
Please sign in to comment.