[mlir][spirv] Replace hardcoded attribute strings with op methods

Author: SahilPatidar

mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp

@@ -708,33 +708,37 @@ Serializer::processOp<spirv::CopyMemoryOp>(spirv::CopyMemoryOp op) {
     operands.push_back(id);
   }
 
-  if (auto attr = op->getAttr("memory_access")) {
+  StringRef memory_access = op.getMemoryAccessAttrName().strref();
+  if (auto attr = op->getAttr(memory_access)) {
     operands.push_back(
         static_cast<uint32_t>(cast<spirv::MemoryAccessAttr>(attr).getValue()));
   }
 
-  elidedAttrs.push_back("memory_access");
+  elidedAttrs.push_back(memory_access);
 
-  if (auto attr = op->getAttr("alignment")) {
+  StringRef alignment = op.getAlignmentAttrName().strref();
+  if (auto attr = op->getAttr(alignment)) {
     operands.push_back(static_cast<uint32_t>(
         cast<IntegerAttr>(attr).getValue().getZExtValue()));
   }
 
-  elidedAttrs.push_back("alignment");
+  elidedAttrs.push_back(alignment);
 
-  if (auto attr = op->getAttr("source_memory_access")) {
+  StringRef source_memory_access = op.getSourceMemoryAccessAttrName().strref();
+  if (auto attr = op->getAttr(source_memory_access)) {
     operands.push_back(
         static_cast<uint32_t>(cast<spirv::MemoryAccessAttr>(attr).getValue()));
   }
 
-  elidedAttrs.push_back("source_memory_access");
+  elidedAttrs.push_back(source_memory_access);
 
-  if (auto attr = op->getAttr("source_alignment")) {
+  StringRef source_alignment = op.getSourceAlignmentAttrName().strref();
+  if (auto attr = op->getAttr(source_alignment)) {
     operands.push_back(static_cast<uint32_t>(
         cast<IntegerAttr>(attr).getValue().getZExtValue()));
   }
 
-  elidedAttrs.push_back("source_alignment");
+  elidedAttrs.push_back(source_alignment);
   if (failed(emitDebugLine(functionBody, op.getLoc())))
     return failure();
   encodeInstructionInto(functionBody, spirv::Opcode::OpCopyMemory, operands);