Skip to content

Commit f47a5df

Browse files
committed
[lit] Try to fix new test from 28412d1 under Windows
`llvm/utils/lit/tests/Inputs/shtest-define/value-escaped.txt` broke at least at <https://lab.llvm.org/buildbot/#/builders/216/builds/10114>. The problem appears to be a non-portable `echo` command line.
1 parent 143f3bf commit f47a5df

File tree

1 file changed

+4
-1
lines changed
  • llvm/utils/lit/tests/Inputs/shtest-define

1 file changed

+4
-1
lines changed

llvm/utils/lit/tests/Inputs/shtest-define/lit.cfg

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
import lit.formats
22
config.name = 'shtest-define'
33
config.suffixes = ['.txt']
4-
config.test_format = lit.formats.ShTest()
4+
# Use lit's internal shell to avoid shell portability issues within RUN lines
5+
# (e.g., for 'echo' commands in Windows). Those issues should be orthogonal to
6+
# the substitution behavior we are trying to test.
7+
config.test_format = lit.formats.ShTest(execute_external=False)
58
config.test_source_root = None
69
config.test_exec_root = None
710

0 commit comments

Comments
 (0)