Skip to content

[llvm-lit] Consolidate logic for enabling internal shell for all test suites #106636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connieyzhu opened this issue Aug 29, 2024 · 0 comments
Open

Comments

@connieyzhu
Copy link
Contributor

connieyzhu commented Aug 29, 2024

As mentioned in RFC: Enabling the Lit Internal Shell by Default, we are in the process of turning on lit's internal shell across all LLVM test suites. We have been turning on the internal shell for each test suite one-by-one as we resolve bugs with the internal shell.

As of now, our strategy for doing so is to edit the lit configs for each test suite with the following lines:

use_lit_shell = True
lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL")
if lit_shell_env:
    use_lit_shell = lit.util.pythonize_bool(lit_shell_env)

config.test_format = lit.formats.ShTest(execute_external=not use_lit_shell)

However, there should eventually be a way to enable the internal shell for the entire project without having to insert the above lines separately for each test suite. This issue was brought up in this comment: #106458 (review).

#102704 tracks the current status of being able to turn on the internal shell by default, and can serve as an indicator for when this issue can be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants