Skip to content

[DirectX] convert vector to array for groupshared #92153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
python3kgae opened this issue May 14, 2024 · 2 comments
Closed

[DirectX] convert vector to array for groupshared #92153

python3kgae opened this issue May 14, 2024 · 2 comments
Assignees
Labels
backend:DirectX duplicate Resolved as duplicate

Comments

@python3kgae
Copy link
Contributor

DXIL requires vector to be removed
https://github.com/microsoft/DirectXShaderCompiler/blob/main/docs/DXIL.rst#vectors

Normally, vectors are removed by the scalarizer.
However, for groupshared memory, keeping elements of vector next to each other helps maintain the layout so that the data can be loaded/stored in a continuous address.
This will be done by convert vector into array.

AC:
A pass to convert vector into array.
Test.

@damyanp
Copy link
Contributor

damyanp commented Jul 2, 2024

Refine this once #92422 has built up a list of subtasks.

@farzonl
Copy link
Member

farzonl commented Nov 13, 2024

This looks like a dupe of #107920

@farzonl farzonl closed this as completed Nov 13, 2024
@farzonl farzonl self-assigned this Nov 13, 2024
@EugeneZelenko EugeneZelenko added the duplicate Resolved as duplicate label Nov 13, 2024
@EugeneZelenko EugeneZelenko closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:DirectX duplicate Resolved as duplicate
Projects
Status: Closed
Development

No branches or pull requests

4 participants