diff --git a/mlir/test/lit.cfg.py b/mlir/test/lit.cfg.py index 98d0ddd9a2be1..f0d4f35ba3e22 100644 --- a/mlir/test/lit.cfg.py +++ b/mlir/test/lit.cfg.py @@ -18,12 +18,15 @@ # name: The name of this test suite. config.name = "MLIR" +# TODO: Consolidate the logic for turning on the internal shell by default for all LLVM test suites. +# See https://github.com/llvm/llvm-project/issues/106636 for more details. +# # We prefer the lit internal shell which provides a better user experience on failures # unless the user explicitly disables it with LIT_USE_INTERNAL_SHELL=0 env var. use_lit_shell = True lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL") if lit_shell_env: - use_lit_shell = not lit.util.pythonize_bool(lit_shell_env) + use_lit_shell = lit.util.pythonize_bool(lit_shell_env) config.test_format = lit.formats.ShTest(execute_external=not use_lit_shell) diff --git a/polly/test/UnitIsl/lit.cfg b/polly/test/UnitIsl/lit.cfg index 0944d543572d8..4b68f1460c3d8 100644 --- a/polly/test/UnitIsl/lit.cfg +++ b/polly/test/UnitIsl/lit.cfg @@ -17,12 +17,15 @@ config.name = 'Polly - isl unit tests' # For now we require '&&' between commands, until they get globally killed and # the test runner updated. # +# TODO: Consolidate the logic for turning on the internal shell by default for all LLVM test suites. +# See https://github.com/llvm/llvm-project/issues/106636 for more details. +# # We prefer the lit internal shell which provides a better user experience on failures # unless the user explicitly disables it with LIT_USE_INTERNAL_SHELL=0 env var. use_lit_shell = True lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL") if lit_shell_env: - use_lit_shell = not lit.util.pythonize_bool(lit_shell_env) + use_lit_shell = lit.util.pythonize_bool(lit_shell_env) config.test_format = lit.formats.ShTest(execute_external=not use_lit_shell) diff --git a/polly/test/lit.cfg b/polly/test/lit.cfg index 156c1f97f5d3a..075ebdacbdc94 100644 --- a/polly/test/lit.cfg +++ b/polly/test/lit.cfg @@ -20,12 +20,15 @@ config.name = 'Polly' # For now we require '&&' between commands, until they get globally killed and # the test runner updated. # +# TODO: Consolidate the logic for turning on the internal shell by default for all LLVM test suites. +# See https://github.com/llvm/llvm-project/issues/106636 for more details. +# # We prefer the lit internal shell which provides a better user experience on failures # unless the user explicitly disables it with LIT_USE_INTERNAL_SHELL=0 env var. use_lit_shell = True lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL") if lit_shell_env: - use_lit_shell = not lit.util.pythonize_bool(lit_shell_env) + use_lit_shell = lit.util.pythonize_bool(lit_shell_env) config.test_format = lit.formats.ShTest(execute_external=not use_lit_shell)