diff --git a/clang/lib/Basic/TargetID.cpp b/clang/lib/Basic/TargetID.cpp index fa1bfec2aacb9..b42d1f07013c2 100644 --- a/clang/lib/Basic/TargetID.cpp +++ b/clang/lib/Basic/TargetID.cpp @@ -92,11 +92,9 @@ parseTargetIDWithFormatCheckingOnly(llvm::StringRef TargetID, if (Sign != '+' && Sign != '-') return std::nullopt; bool IsOn = Sign == '+'; - auto Loc = FeatureMap->find(Feature); // Each feature can only show up at most once in target ID. - if (Loc != FeatureMap->end()) + if (!FeatureMap->try_emplace(Feature, IsOn).second) return std::nullopt; - (*FeatureMap)[Feature] = IsOn; Features = Splits.second; } return Processor; @@ -147,15 +145,15 @@ getConflictTargetIDCombination(const std::set &TargetIDs) { struct Info { llvm::StringRef TargetID; llvm::StringMap Features; + Info(llvm::StringRef TargetID, const llvm::StringMap &Features) + : TargetID(TargetID), Features(Features) {} }; llvm::StringMap FeatureMap; for (auto &&ID : TargetIDs) { llvm::StringMap Features; llvm::StringRef Proc = *parseTargetIDWithFormatCheckingOnly(ID, &Features); - auto Loc = FeatureMap.find(Proc); - if (Loc == FeatureMap.end()) - FeatureMap[Proc] = Info{ID, Features}; - else { + auto [Loc, Inserted] = FeatureMap.try_emplace(Proc, ID, Features); + if (!Inserted) { auto &ExistingFeatures = Loc->second.Features; if (llvm::any_of(Features, [&](auto &F) { return ExistingFeatures.count(F.first()) == 0;