From cb9abe5ecc53495c2bf6060dfb211520aed39cd5 Mon Sep 17 00:00:00 2001 From: thetruestblue Date: Fri, 28 Feb 2025 13:06:59 -0800 Subject: [PATCH 1/2] [RTSan][Apple] Disable AccessingALargeAtomicVariableDiesWhenRealtime on Apple devices Disabling this test since it failing Apple CI jobs: https://green.lab.llvm.org/job/llvm.org/job/clang-stage1-RA/3694/testReport/RealtimeSanitizer-Unit/__Rtsan-x86_64h-Test_TestRtsan/AccessingALargeAtomicVariableDiesWhenRealtime/ rdar://145488759 --- compiler-rt/lib/rtsan/tests/rtsan_test_functional.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/compiler-rt/lib/rtsan/tests/rtsan_test_functional.cpp b/compiler-rt/lib/rtsan/tests/rtsan_test_functional.cpp index e05d7ae78b5d9..85ccc98400918 100644 --- a/compiler-rt/lib/rtsan/tests/rtsan_test_functional.cpp +++ b/compiler-rt/lib/rtsan/tests/rtsan_test_functional.cpp @@ -171,6 +171,9 @@ TEST(TestRtsan, CopyingALambdaWithLargeCaptureDiesWhenRealtime) { } TEST(TestRtsan, AccessingALargeAtomicVariableDiesWhenRealtime) { + #ifdef __APPLE__ + GTEST_SKIP(); // Test is failing on Apple Devices. + #endif std::atomic small_atomic{0.0f}; ASSERT_TRUE(small_atomic.is_lock_free()); RealtimeInvoke([&small_atomic]() { From 813b9c41047fa93a119b3f10caa8998c91bffe31 Mon Sep 17 00:00:00 2001 From: thetruestblue Date: Fri, 28 Feb 2025 13:18:30 -0800 Subject: [PATCH 2/2] Update rtsan_test_functional.cpp --- compiler-rt/lib/rtsan/tests/rtsan_test_functional.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/compiler-rt/lib/rtsan/tests/rtsan_test_functional.cpp b/compiler-rt/lib/rtsan/tests/rtsan_test_functional.cpp index 85ccc98400918..8e19b2403f70d 100644 --- a/compiler-rt/lib/rtsan/tests/rtsan_test_functional.cpp +++ b/compiler-rt/lib/rtsan/tests/rtsan_test_functional.cpp @@ -171,9 +171,9 @@ TEST(TestRtsan, CopyingALambdaWithLargeCaptureDiesWhenRealtime) { } TEST(TestRtsan, AccessingALargeAtomicVariableDiesWhenRealtime) { - #ifdef __APPLE__ +#ifdef __APPLE__ GTEST_SKIP(); // Test is failing on Apple Devices. - #endif +#endif std::atomic small_atomic{0.0f}; ASSERT_TRUE(small_atomic.is_lock_free()); RealtimeInvoke([&small_atomic]() {