diff --git a/clang/lib/Sema/HLSLExternalSemaSource.cpp b/clang/lib/Sema/HLSLExternalSemaSource.cpp index 38bde7c28e946..726581d131623 100644 --- a/clang/lib/Sema/HLSLExternalSemaSource.cpp +++ b/clang/lib/Sema/HLSLExternalSemaSource.cpp @@ -266,6 +266,19 @@ void HLSLExternalSemaSource::defineHLSLTypesWithForwardDeclarations() { *SemaPtr, HLSLNamespace, /*isTypedBuffer*/ true); ConceptDecl *StructuredBufferConcept = constructBufferConceptDecl( *SemaPtr, HLSLNamespace, /*isTypedBuffer*/ false); + + Decl = BuiltinTypeDeclBuilder(*SemaPtr, HLSLNamespace, "Buffer") + .addSimpleTemplateParams({"element_type"}, TypedBufferConcept) + .finalizeForwardDeclaration(); + + onCompletion(Decl, [this](CXXRecordDecl *Decl) { + setupBufferType(Decl, *SemaPtr, ResourceClass::SRV, /*IsROV=*/false, + /*RawBuffer=*/false) + .addArraySubscriptOperators() + .addLoadMethods() + .completeDefinition(); + }); + Decl = BuiltinTypeDeclBuilder(*SemaPtr, HLSLNamespace, "RWBuffer") .addSimpleTemplateParams({"element_type"}, TypedBufferConcept) .finalizeForwardDeclaration(); diff --git a/clang/test/AST/HLSL/TypedBuffers-AST.hlsl b/clang/test/AST/HLSL/TypedBuffers-AST.hlsl index dad1ef17a1f86..f716501a35ad9 100644 --- a/clang/test/AST/HLSL/TypedBuffers-AST.hlsl +++ b/clang/test/AST/HLSL/TypedBuffers-AST.hlsl @@ -1,11 +1,18 @@ // RUN: %clang_cc1 -Wno-hlsl-implicit-binding -triple dxil-pc-shadermodel6.0-library -x hlsl -ast-dump -DEMPTY \ // RUN: -DRESOURCE=RWBuffer %s | FileCheck -DRESOURCE=RWBuffer -check-prefix=EMPTY %s // +// RUN: %clang_cc1 -Wno-hlsl-implicit-binding -triple dxil-pc-shadermodel6.0-library -x hlsl -ast-dump -DEMPTY \ +// RUN: -DRESOURCE=Buffer %s | FileCheck -DRESOURCE=Buffer -check-prefix=EMPTY %s +// // RUN: %clang_cc1 -Wno-hlsl-implicit-binding -triple dxil-pc-shadermodel6.0-library -x hlsl -ast-dump \ // RUN: -DRESOURCE=RWBuffer %s | FileCheck -DRESOURCE=RWBuffer \ // RUN: -check-prefixes=CHECK,CHECK-UAV %s +// +// RUN: %clang_cc1 -Wno-hlsl-implicit-binding -triple dxil-pc-shadermodel6.0-library -x hlsl -ast-dump \ +// RUN: -DRESOURCE=Buffer %s | FileCheck -DRESOURCE=Buffer \ +// RUN: -check-prefixes=CHECK,CHECK-SRV %s -// TODO: Add AST tests for Buffer and RasterizerOrderedBuffer here +// TODO: Add AST tests for RasterizerOrderedBuffer here // This test tests two different AST generations each typed buffer. // The "EMPTY" test mode verifies the AST generated by forward declaration @@ -54,6 +61,7 @@ RESOURCE Buffer; // CHECK: FinalAttr {{.*}} Implicit final // CHECK-NEXT: FieldDecl {{.*}} implicit __handle '__hlsl_resource_t // CHECK-UAV-SAME{LITERAL}: [[hlsl::resource_class(UAV)]] +// CHECK-SRV-SAME{LITERAL}: [[hlsl::resource_class(SRV)]] // CHECK-SAME{LITERAL}: [[hlsl::contained_type(element_type)]] // Default constructor @@ -125,7 +133,8 @@ RESOURCE Buffer; // CHECK-NEXT: ImplicitCastExpr {{.*}} // CHECK-NEXT: DeclRefExpr {{.*}} '' Function {{.*}} '__builtin_hlsl_resource_getpointer' 'void (...) noexcept' // CHECK-NEXT: MemberExpr {{.*}} '__hlsl_resource_t -// CHECK-SAME{LITERAL}: [[hlsl::resource_class(UAV)]] +// CHECK-UAV-SAME{LITERAL}: [[hlsl::resource_class(UAV)]] +// CHECK-SRV-SAME{LITERAL}: [[hlsl::resource_class(SRV)]] // CHECK-SAME{LITERAL}: [[hlsl::contained_type(element_type)]] // CHECK-SAME: ' lvalue .__handle {{.*}} // CHECK-NEXT: CXXThisExpr {{.*}} 'const [[RESOURCE]]' lvalue implicit this @@ -141,7 +150,8 @@ RESOURCE Buffer; // CHECK-NEXT: ImplicitCastExpr {{.*}} // CHECK-NEXT: DeclRefExpr {{.*}} '' Function {{.*}} '__builtin_hlsl_resource_getpointer' 'void (...) noexcept' // CHECK-NEXT: MemberExpr {{.*}} '__hlsl_resource_t -// CHECK-SAME{LITERAL}: [[hlsl::resource_class(UAV)]] +// CHECK-UAV-SAME{LITERAL}: [[hlsl::resource_class(UAV)]] +// CHECK-SRV-SAME{LITERAL}: [[hlsl::resource_class(SRV)]] // CHECK-SAME{LITERAL}: [[hlsl::contained_type(element_type)]] // CHECK-SAME: ' lvalue .__handle {{.*}} // CHECK-NEXT: CXXThisExpr {{.*}} '[[RESOURCE]]' lvalue implicit this @@ -159,7 +169,8 @@ RESOURCE Buffer; // CHECK-NEXT: ImplicitCastExpr {{.*}} // CHECK-NEXT: DeclRefExpr {{.*}} '' Function {{.*}} '__builtin_hlsl_resource_getpointer' 'void (...) noexcept' // CHECK-NEXT: MemberExpr {{.*}} '__hlsl_resource_t -// CHECK-SAME{LITERAL}: [[hlsl::resource_class(UAV)]] +// CHECK-UAV-SAME{LITERAL}: [[hlsl::resource_class(UAV)]] +// CHECK-SRV-SAME{LITERAL}: [[hlsl::resource_class(SRV)]] // CHECK-SAME{LITERAL}: [[hlsl::contained_type(element_type)]] // CHECK-SAME: ' lvalue .__handle {{.*}} // CHECK-NEXT: CXXThisExpr {{.*}} '[[RESOURCE]]' lvalue implicit this @@ -173,4 +184,5 @@ RESOURCE Buffer; // CHECK-NEXT: FinalAttr {{.*}} Implicit final // CHECK-NEXT: FieldDecl {{.*}} implicit referenced __handle '__hlsl_resource_t // CHECK-UAV-SAME{LITERAL}: [[hlsl::resource_class(UAV)]] +// CHECK-SRV-SAME{LITERAL}: [[hlsl::resource_class(SRV)]] // CHECK-SAME{LITERAL}: [[hlsl::contained_type(float)]] diff --git a/clang/test/SemaHLSL/BuiltIns/Buffers.hlsl b/clang/test/SemaHLSL/BuiltIns/Buffers.hlsl new file mode 100644 index 0000000000000..477a16a454a9c --- /dev/null +++ b/clang/test/SemaHLSL/BuiltIns/Buffers.hlsl @@ -0,0 +1,114 @@ +// RUN: %clang_cc1 -Wno-hlsl-implicit-binding -triple dxil-pc-shadermodel6.0-compute -x hlsl -fsyntax-only -verify %s + +typedef vector float3; +typedef vector double2; +typedef vector double3; + + +// expected-error@+1 {{class template 'Buffer' requires template arguments}} +Buffer BufferErr1; + +// expected-error@+1 {{too few template arguments for class template 'Buffer'}} +Buffer<> BufferErr2; + +// test implicit Buffer concept +Buffer r1; +Buffer r2; +Buffer Buff; +Buffer r4; + +// expected-error@+4 {{constraints not satisfied for class template 'Buffer'}} +// expected-note@*:* {{template declaration from hidden source: template requires __is_typed_resource_element_compatible class Buffer}} +// expected-note@*:* {{because 'hlsl::Buffer' does not satisfy '__is_typed_resource_element_compatible'}} +// expected-note@*:* {{because '__builtin_hlsl_is_typed_resource_element_compatible(hlsl::Buffer)' evaluated to false}} +Buffer > r5; + +struct s { + int x; +}; + +struct Empty {}; + +template struct TemplatedBuffer { + T a; +}; + +template struct TemplatedVector { + vector v; +}; + +// structs not allowed +// expected-error@+4 {{constraints not satisfied for class template 'Buffer'}} +// expected-note@*:* {{template declaration from hidden source: template requires __is_typed_resource_element_compatible class Buffer}} +// expected-note@*:* {{because 's' does not satisfy '__is_typed_resource_element_compatible'}} +// expected-note@*:* {{because '__builtin_hlsl_is_typed_resource_element_compatible(s)' evaluated to false}} +Buffer r6; +// expected-error@+3 {{constraints not satisfied for class template 'Buffer'}} +// expected-note@*:* {{because 'Empty' does not satisfy '__is_typed_resource_element_compatible'}} +// expected-note@*:* {{because '__builtin_hlsl_is_typed_resource_element_compatible(Empty)' evaluated to false}} +Buffer r7; + +// expected-error@+3 {{constraints not satisfied for class template 'Buffer'}} +// expected-note@*:* {{because 'TemplatedBuffer' does not satisfy '__is_typed_resource_element_compatible'}} +// expected-note@*:* {{because '__builtin_hlsl_is_typed_resource_element_compatible(TemplatedBuffer)' evaluated to false}} +Buffer > r8; +// expected-error@+3 {{constraints not satisfied for class template 'Buffer'}} +// expected-note@*:* {{because 'TemplatedVector' does not satisfy '__is_typed_resource_element_compatible'}} +// expected-note@*:* {{because '__builtin_hlsl_is_typed_resource_element_compatible(TemplatedVector)' evaluated to false}} +Buffer > r9; + +// arrays not allowed +// expected-error@+3 {{constraints not satisfied for class template 'Buffer'}} +// expected-note@*:* {{because 'half[4]' does not satisfy '__is_typed_resource_element_compatible'}} +// expected-note@*:* {{because '__builtin_hlsl_is_typed_resource_element_compatible(half[4])' evaluated to false}} +Buffer r10; + +typedef vector int8; +// expected-error@+3 {{constraints not satisfied for class template 'Buffer'}} +// expected-note@*:* {{because 'vector' (vector of 8 'int' values) does not satisfy '__is_typed_resource_element_compatible'}} +// expected-note@*:* {{because '__builtin_hlsl_is_typed_resource_element_compatible(vector)' evaluated to false}} +Buffer r11; + +typedef int MyInt; +Buffer r12; + +// expected-error@+3 {{constraints not satisfied for class template 'Buffer'}} +// expected-note@*:* {{because 'bool' does not satisfy '__is_typed_resource_element_compatible'}} +// expected-note@*:* {{because '__builtin_hlsl_is_typed_resource_element_compatible(bool)' evaluated to false}} +Buffer r13; + +// expected-error@+3 {{constraints not satisfied for class template 'Buffer'}} +// expected-note@*:* {{because 'vector' (vector of 2 'bool' values) does not satisfy '__is_typed_resource_element_compatible'}} +// expected-note@*:* {{because '__builtin_hlsl_is_typed_resource_element_compatible(vector)' evaluated to false}} +Buffer> r14; + +enum numbers { one, two, three }; + +// expected-error@+3 {{constraints not satisfied for class template 'Buffer'}} +// expected-note@*:* {{because 'numbers' does not satisfy '__is_typed_resource_element_compatible'}} +// expected-note@*:* {{because '__builtin_hlsl_is_typed_resource_element_compatible(numbers)' evaluated to false}} +Buffer r15; + +// expected-error@+3 {{constraints not satisfied for class template 'Buffer'}} +// expected-note@*:* {{because 'vector' (vector of 3 'double' values) does not satisfy '__is_typed_resource_element_compatible'}} +// expected-note@*:* {{because '__builtin_hlsl_is_typed_resource_element_compatible(vector)' evaluated to false}} +Buffer r16; + + +struct threeDoubles { + double a; + double b; + double c; +}; + +// expected-error@+3 {{constraints not satisfied for class template 'Buffer'}} +// expected-note@*:* {{because 'threeDoubles' does not satisfy '__is_typed_resource_element_compatible'}} +// expected-note@*:* {{because '__builtin_hlsl_is_typed_resource_element_compatible(threeDoubles)' evaluated to false}} +Buffer BufferErr3; + + +[numthreads(1,1,1)] +void main() { + (void)Buff.__handle; // expected-error {{'__handle' is a private member of 'hlsl::Buffer>'}} + // expected-note@* {{implicitly declared private here}} +} diff --git a/clang/test/SemaHLSL/BuiltIns/RWBuffers.hlsl b/clang/test/SemaHLSL/BuiltIns/RWBuffers.hlsl index 91e96b995585f..b4f59393a1768 100644 --- a/clang/test/SemaHLSL/BuiltIns/RWBuffers.hlsl +++ b/clang/test/SemaHLSL/BuiltIns/RWBuffers.hlsl @@ -14,7 +14,7 @@ RWBuffer<> BufferErr2; // test implicit RWBuffer concept RWBuffer r1; RWBuffer r2; -RWBuffer Buffer; +RWBuffer Buff; RWBuffer r4; // expected-error@+4 {{constraints not satisfied for class template 'RWBuffer'}} @@ -109,6 +109,6 @@ RWBuffer BufferErr3; [numthreads(1,1,1)] void main() { - (void)Buffer.__handle; // expected-error {{'__handle' is a private member of 'hlsl::RWBuffer>'}} + (void)Buff.__handle; // expected-error {{'__handle' is a private member of 'hlsl::RWBuffer>'}} // expected-note@* {{implicitly declared private here}} } diff --git a/clang/test/SemaHLSL/BuiltIns/StructuredBuffers.hlsl b/clang/test/SemaHLSL/BuiltIns/StructuredBuffers.hlsl index 991b04c80ac86..6596f73b25170 100644 --- a/clang/test/SemaHLSL/BuiltIns/StructuredBuffers.hlsl +++ b/clang/test/SemaHLSL/BuiltIns/StructuredBuffers.hlsl @@ -2,7 +2,7 @@ typedef vector float3; -StructuredBuffer Buffer; +StructuredBuffer Buff; // expected-error@+2 {{class template 'StructuredBuffer' requires template arguments}} // expected-note@*:* {{template declaration from hidden source: template requires __is_structured_resource_element_compatible class StructuredBuffer {}}} @@ -26,6 +26,6 @@ StructuredBuffer BufferErr4; [numthreads(1,1,1)] void main() { - (void)Buffer.__handle; // expected-error {{'__handle' is a private member of 'hlsl::StructuredBuffer>'}} + (void)Buff.__handle; // expected-error {{'__handle' is a private member of 'hlsl::StructuredBuffer>'}} // expected-note@* {{implicitly declared private here}} }