diff --git a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp index f51ada8d08b5e..7a62429d37004 100644 --- a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp +++ b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp @@ -243,6 +243,10 @@ class SliceConverter : public OpConversionPattern { ConversionPatternRewriter &rewriter) const final { Location loc = sliceOp.getLoc(); Value input = adaptor.getInput(); + ShapedType resultType = cast(sliceOp.getType()); + if (llvm::isa(resultType) || + resultType.getRank() != static_cast(sliceOp.getSize().size())) + return failure(); SmallVector strides, sizes; ArrayRef starts = sliceOp.getStart(); strides.resize(cast(sliceOp.getType()).getRank(), 1); diff --git a/mlir/test/Conversion/TosaToTensor/tosa-to-tensor-invalid.mlir b/mlir/test/Conversion/TosaToTensor/tosa-to-tensor-invalid.mlir new file mode 100644 index 0000000000000..cfa1c41f24679 --- /dev/null +++ b/mlir/test/Conversion/TosaToTensor/tosa-to-tensor-invalid.mlir @@ -0,0 +1,15 @@ +// RUN: mlir-opt --split-input-file -pass-pipeline="builtin.module(func.func(tosa-to-tensor))" %s -verify-diagnostics + +// CHECK-LABEL: @slice_resultType_unranked +func.func @slice_resultType_unranked(%arg0: tensor) -> (tensor<*xf32>) { + // expected-error@+1 {{failed to legalize operation 'tosa.slice'}} + %0 = "tosa.slice"(%arg0) {start = array, size = array} : (tensor) -> (tensor<*xf32>) + return %0 : tensor<*xf32> +} + +// CHECK-LABEL: @slice_resultRank_neq_opSize +func.func @slice_resultRank_neq_opSize(%arg0: tensor<12xf32>) -> (tensor<2xf32>) { + // expected-error@+1 {{failed to legalize operation 'tosa.slice'}} + %0 = "tosa.slice"(%arg0) {start = array, size = array} : (tensor<12xf32>) -> (tensor<2xf32>) + return %0 : tensor<2xf32> +}