[ClangBuilder] Pass -k to make for test-suite runs (#251)

When
llvm/llvm-lnt@7688741
enabled using Ninja, it removed the -k flag from make. -k causes make to
carry on if there's a build failure.

Without this flag, a single compilation failure turns into thousands of
missing executables in the final results. As subsequent targets are not
built.

llvm/llvm-lnt#25 is adding an option to the lnt
runner to pass options to the build tool.

This PR uses that to pass -k to make to restore the old behaviour on the
build bots.

Author: DavidSpickett

zorg/buildbot/builders/ClangBuilder.py

@@ -527,7 +527,9 @@ def _getClangCMakeBuildFactory(
                               '--test-suite', test_suite_dir,
                               '--cc', cc,
                               '--cxx', cxx,
-                              '--use-lit', lit]
+                              '--use-lit', lit,
+                              # Carry on building even if there is a failure.
+                              '--build-tool-options', '"-k"']
             # Enable fortran if flang is checked out
             if checkout_flang:
                 fortran_flags = [