chore(validator): enforce body length

Author: sebastien-boulle

README.md

@@ -188,12 +188,13 @@ See the [open issues](https://github.com/lumapps/commit-msg-validator/issues) fo
 - [x] enforce the overall commit message structure
 - [x] enforce the overall commit header structure
 - [x] enforce the overall commit header lenght
-- [ ] enforce the commit body length
-- [ ] enforce the JIRA reference
-- [ ] enforce the BROKEN part
 - [x] enforce the commit type
 - [x] enforce the commit scope
 - [x] enforce the commit subject
+- [x] enforce the commit body length
+- [ ] enforce the JIRA reference
+- [ ] enforce the BROKEN part
+- [ ] avoid trailing space
 - [ ] allow automated revert commit
 - [ ] allow fixup! and squash! commit with an option
 

validator.bats

@@ -373,6 +373,28 @@ BROKEN:
   [ "$status" -eq 0 ]
 }
 
+@test "body with 101 line length should be rejected" {
+  MESSAGE='
+12345678 012345678 012345678 012345678 012345678 012345678 012345678 012345678 012345678 012345678 01
+
+LUM-2345'
+
+  run validate_body_length "$MESSAGE"
+  [[ "$status" -eq $ERROR_BODY_LENGTH ]]
+}
+@test "body with 100 line length should be valid" {
+  MESSAGE='
+1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
+12345678 012345678 012345678 012345678 012345678 012345678 012345678 012345678 012345678 012345678 0
+
+1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
+
+LUM-2345'
+
+  run validate_body_length "$MESSAGE"
+  [[ "$status" -eq 0 ]]
+}
+
 @test "overall validation invalid structure" {
   MESSAGE='plop
 plop'
@@ -428,6 +450,17 @@ LUM-2345'
   [[ "$status" -eq $ERROR_SUBJECT ]]
 }
 
+@test "overall validation invalid body length" {
+  MESSAGE='feat(scope1): subject
+
+12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901
+
+LUM-2345'
+
+  run validate "$MESSAGE"
+  [[ "$status" -eq $ERROR_BODY_LENGTH ]]
+}
+
 @test "overall validation" {
   MESSAGE='feat(scope1): subject
 

validator.sh

@@ -13,6 +13,7 @@ readonly ERROR_HEADER_LENGTH=3
 readonly ERROR_TYPE=4
 readonly ERROR_SCOPE=5
 readonly ERROR_SUBJECT=6
+readonly ERROR_BODY_LENGTH=7
 
 GLOBAL_HEADER=""
 GLOBAL_BODY=""
@@ -160,6 +161,21 @@ validate_subject() {
   fi
 }
 
+validate_body_length() {
+  local BODY=$1
+  local LINE=""
+
+  while IFS= read -r LINE ;
+  do
+    local LENGTH=`echo -n "$LINE" | wc -c`
+
+    if [ $LENGTH -gt 100 ]; then
+        echo -e "body message line length is more than 100 charaters"
+        exit $ERROR_BODY_LENGTH
+    fi
+  done <<< "$BODY"
+}
+
 validate() {
    local COMMIT_MSG="$1"
 
@@ -180,4 +196,6 @@ validate() {
    validate_type "$TYPE"
    validate_scope "$SCOPE"
    validate_subject "$SUBJECT"
+
+   validate_body_length "$BODY"
 }