Reduced limiting values

Author: rogyar

app/code/Magento/GraphQl/etc/di.xml

@@ -99,8 +99,8 @@
     </type>
     <type name="Magento\Framework\GraphQl\Query\QueryComplexityLimiter">
         <arguments>
-            <argument name="queryDepth" xsi:type="number">50</argument>
-            <argument name="queryComplexity" xsi:type="number">150</argument>
+            <argument name="queryDepth" xsi:type="number">10</argument>
+            <argument name="queryComplexity" xsi:type="number">50</argument>
         </arguments>
     </type>
 </config>

dev/tests/api-functional/testsuite/Magento/GraphQl/Framework/QueryComplexityLimiterTest.php

@@ -86,109 +86,6 @@ public function testQueryComplexityIsLimited()
                       id
                       types
                     }
-                    categories {
-                      id
-                      position
-                      level
-                      url_key
-                      url_path
-                      product_count
-                      breadcrumbs {
-                        category_id
-                        category_name
-                        category_url_key
-                      }
-                      products {
-                        items {
-                          name
-                          special_from_date
-                          special_to_date
-                          new_to_date
-                          new_from_date
-                          tier_price
-                          manufacturer
-                          thumbnail
-                          sku
-                          image
-                          canonical_url
-                          updated_at
-                          created_at
-                          categories {
-                            id
-                            position
-                            level
-                            url_key
-                            url_path
-                            product_count
-                            breadcrumbs {
-                              category_id
-                              category_name
-                              category_url_key
-                            }
-                            products {
-                              items {
-                                name
-                                special_from_date
-                                special_to_date
-                                new_to_date
-                                new_from_date
-                                tier_price
-                                manufacturer
-                                sku
-                                image
-                                canonical_url
-                                updated_at
-                                created_at
-                                categories {
-                                  id
-                                  position
-                                  level
-                                  url_key
-                                  url_path
-                                  product_count
-                                  breadcrumbs {
-                                    category_id
-                                    category_name
-                                    category_url_key
-                                  }
-                                  products {
-                                    items {
-                                      name
-                                      special_from_date
-                                      special_to_date
-                                      new_to_date
-                                      new_from_date
-                                      tier_price
-                                      manufacturer
-                                      sku
-                                      image
-                                      thumbnail
-                                      canonical_url
-                                      updated_at
-                                      created_at
-                                      categories {
-                                        id
-                                        position
-                                        level
-                                        url_key
-                                        url_path
-                                        product_count
-                                        default_sort_by
-                                        breadcrumbs {
-                                          category_id
-                                          category_name
-                                          category_url_key
-                                        }
-                                      }
-                                    }
-                                  }
-                                }
-                              }
-                            }
-                          }
-                        }
-                      }
-                    }
                   }
                 }
               }
@@ -201,7 +98,7 @@ public function testQueryComplexityIsLimited()
 }
 QUERY;
 
-        self::expectExceptionMessageRegExp('/Max query complexity should be 150 but got 151/');
+        self::expectExceptionMessageRegExp('/Max query complexity should be 50 but got 62/');
         $this->graphQlQuery($query);
     }
 
@@ -238,71 +135,7 @@ public function testQueryDepthIsLimited()
                                       categories {
                                         products {
                                           items {
-                                            categories {
-                                              products {
-                                                items {
-                                                  categories {
-                                                    products {
-                                                      items {
-                                                        categories {
-                                                          products {
-                                                            items {
-                                                              name,
-                                                              categories {
-                                                                products {
-                                                                  items {
-                                                                    categories {
-                                                                      products {
-                                                                        items {
-                                                                          categories{
-                                                                            products {
-                                                                              items {
-                                                                                categories {
-                                                                                  products {
-                                                                                    items {
-                                                                                      categories {
-                                                                                        products {
-                                                                                          items {
-                                                                                            categories {
-                                                                                              products {
-                                                                                                items {
-                                                                                                  name,
-                                                                                                  categories {
-                                                                                                    products {
-                                                                                                      items {
-                                                                                                        categories {
-                                                                                                          name
-                                                                                                        }
-                                                                                                      }
-                                                                                                    }
-                                                                                                  }
-                                                                                                }
-                                                                                              }
-                                                                                            }
-                                                                                          }
-                                                                                        }
-                                                                                      }
-                                                                                    }
-                                                                                  }
-                                                                                }
-                                                                              }
-                                                                            }
-                                                                          }
-                                                                        }
-                                                                      }
-                                                                    }
-                                                                  }
-                                                                }
-                                                              }
-                                                            }
-                                                          }
-                                                        }
-                                                      }
-                                                    }
-                                                  }
-                                                }
-                                              }
-                                            }
+                                            name
                                           }
                                         }
                                       }
@@ -326,7 +159,7 @@ public function testQueryDepthIsLimited()
   }
 }
 QUERY;
-        self::expectExceptionMessageRegExp('/Max query depth should be 50 but got 51/');
+        self::expectExceptionMessageRegExp('/Max query depth should be 10 but got 20/');
         $this->graphQlQuery($query);
     }
 }

lib/internal/Magento/Framework/GraphQl/Query/QueryComplexityLimiter.php

@@ -34,8 +34,8 @@ class QueryComplexityLimiter
      * @param int $queryComplexity
      */
     public function __construct(
-        int $queryDepth = 50,
-        int $queryComplexity = 150
+        int $queryDepth = 10,
+        int $queryComplexity = 50
     ) {
         $this->queryDepth = $queryDepth;
         $this->queryComplexity = $queryComplexity;