Skip to content

Commit afda713

Browse files
committed
MC-30392: De-couple Authorize.net payment methods integrations from core in 2.4.0
1 parent 9bc59f8 commit afda713

File tree

4 files changed

+9
-18
lines changed

4 files changed

+9
-18
lines changed

dev/tests/unit/Magento/FunctionalTestFramework/Test/Util/ActionMergeUtilTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ public function testValidMagentoCLISecretFunction()
221221
$actionObjectOne = new ActionObject(
222222
'actionKey1',
223223
'magentoCLI',
224-
['command' => 'config:set cms/wysiwyg/enabled {{_CREDS.payment_authorizenet_login}}']
224+
['command' => 'config:set cms/wysiwyg/enabled {{_CREDS.payment_method_login}}']
225225
);
226226
$actionObject = [$actionObjectOne];
227227

@@ -232,7 +232,7 @@ public function testValidMagentoCLISecretFunction()
232232
$expectedValue = new ActionObject(
233233
'actionKey1',
234234
'magentoCLISecret',
235-
['command' => 'config:set cms/wysiwyg/enabled {{_CREDS.payment_authorizenet_login}}']
235+
['command' => 'config:set cms/wysiwyg/enabled {{_CREDS.payment_method_login}}']
236236
);
237237
$this->assertEquals($expectedValue, $result['actionKey1']);
238238
}
@@ -248,7 +248,7 @@ public function testValidCreateDataSecretFunction()
248248
$actionObjectOne = new ActionObject(
249249
'actionKey1',
250250
'field',
251-
['value' => '{{_CREDS.payment_authorizenet_login}}']
251+
['value' => '{{_CREDS.payment_method_login}}']
252252
);
253253
$actionObject = [$actionObjectOne];
254254

@@ -259,7 +259,7 @@ public function testValidCreateDataSecretFunction()
259259
$expectedValue = new ActionObject(
260260
'actionKey1',
261261
'field',
262-
['value' => '{{_CREDS.payment_authorizenet_login}}']
262+
['value' => '{{_CREDS.payment_method_login}}']
263263
);
264264
$this->assertEquals($expectedValue, $result['actionKey1']);
265265
}

dev/tests/verification/TestModule/Test/SecretCredentialDataTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@
1414
<field key="price">12.34</field>
1515
</createData>
1616
<createData entity="_defaultProduct" stepKey="createProductWithFieldOverridesUsingSecretCredData1">
17-
<field key="qty">{{_CREDS.payment_authorizenet_trans_key}}</field>
17+
<field key="qty">{{_CREDS.payment_method_trans_key}}</field>
1818
<field key="price">{{_CREDS.carriers_dhl_account_eu}}</field>
1919
</createData>
2020

2121
<fillField selector="{{AdminLoginFormSection.username}}" userInput="Hardcoded" stepKey="fillFieldUsingHardCodedData1"/>
2222
<fillField selector="{{AdminLoginFormSection.username}}" userInput="{{_CREDS.carriers_dhl_id_eu}}" stepKey="fillFieldUsingSecretCredData1"/>
2323

2424
<magentoCLI command="config:set cms/wysiwyg/enabled 0" stepKey="magentoCliUsingHardcodedData1"/>
25-
<magentoCLI command="config:set cms/wysiwyg/enabled {{_CREDS.payment_authorizenet_login}}" stepKey="magentoCliUsingSecretCredData1"/>
25+
<magentoCLI command="config:set cms/wysiwyg/enabled {{_CREDS.payment_method_login}}" stepKey="magentoCliUsingSecretCredData1"/>
2626
</test>
2727
</tests>

dev/tests/verification/Tests/SecretCredentialDataTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public function secretCredentialDataTest(AcceptanceTester $I)
4646
);
4747

4848
$createProductWithFieldOverridesUsingSecretCredData1Fields['qty'] =
49-
$I->getSecret("payment_authorizenet_trans_key");
49+
$I->getSecret("payment_method_trans_key");
5050

5151
$createProductWithFieldOverridesUsingSecretCredData1Fields['price'] =
5252
$I->getSecret("carriers_dhl_account_eu");
@@ -68,7 +68,7 @@ public function secretCredentialDataTest(AcceptanceTester $I)
6868
$I->comment($magentoCliUsingHardcodedData1);
6969

7070
$magentoCliUsingSecretCredData1 = $I->magentoCLI("config:set cms/wysiwyg/enabled " .
71-
$I->getSecret("payment_authorizenet_login"));
71+
$I->getSecret("payment_method_login"));
7272
// stepKey: magentoCliUsingSecretCredData1
7373
$I->comment($magentoCliUsingSecretCredData1);
7474
}

etc/config/.credentials.example

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,6 @@
1919
#magento/carriers_dhl_password_eu=
2020
#magento/carriers_dhl_account_eu=
2121

22-
23-
#magento/payment_authorizenet_login=
24-
#magento/payment_authorizenet_trans_key=
25-
#magento/payment_authorizenet_trans_md5=
26-
27-
#magento/authorizenet_fraud_review_login=
28-
#magento/authorizenet_fraud_review_trans_key=
29-
#magento/authorizenet_fraud_review_md5=
30-
3122
#magento/braintree_enabled_fraud_merchant_account_id=
3223
#magento/braintree_enabled_fraud_merchant_id=
3324
#magento/braintree_enabled_fraud_public_key=
@@ -72,4 +63,4 @@
7263
#magento/payment_paypal_alternative_payment_methods_express_checkout_us_express_checkout_required_express_checkout_required_express_checkout_api_password=
7364
#magento/payment_paypal_alternative_payment_methods_express_checkout_us_express_checkout_required_express_checkout_required_express_checkout_api_signature=
7465

75-
#magento/fraud_protection_signifyd_api_key=
66+
#magento/fraud_protection_signifyd_api_key=

0 commit comments

Comments
 (0)