June 19, 2019

[lenaorobei]

Please add your topic as a comment to the issue. Use following format:
Topic description and link to PR, if any (duration in min)

🎥 recording

[lenaorobei]

• The use of $this->helper(<helper_class>) in phtml templates Documentation for Magento2.Templates.ThisInTemplate rule magento-coding-standard#108 (10 min)

[YevSent]

JWT support out-of-box #188 (10min)

[AlexMaxHorkun]

Read custom layout updates from files #187 (10 min)

[paliarush]

Alternative Checkout Flow #192 (15 min)

[buskamuza]

• Using helpers in templates
  • @joni-jones , @akaplya : it should not be necessary to use helpers, and it should be possible to refactor templates to use view models instead.
  • ✅ preserver the rule in phpcs, no exceptions for templates
  • ✅ make sure that there is a static test that verifies no phpcs:disable added
• JWT support
  • @AlexMaxHorkun : will it be used by anything existing in vanilla Magento? @joni-jones : yes, Cardinal Commerce for 3d secure
  • ✅ no critical objections. Proceed with the proposal review offline
• Alternative Checkout flow
  • @antonkril : add definitions of Cart and Quote
  • @antonkril : why there is separate "Applicable cart rules calculator" service? Will it ever be used w/o Quote?
    • Can be used for calculating estimates in minicart
  • @antonkril : cart rules should not be passed by the client to the Quote. @paliarush : should be under the hood, not from the client. This part should be clarified in the document
  • @antonkril : why do we need totals entity?
  • Billing address should not be part of quote
  • @antonkril : if cart is broken down to quotas by shipping addresses, how to apply discounts applicable only to entire cart?
• Layout updates from files
  • There is already support for layout updates from files per entity
  • Need import from the Product Owner to understand if the option of template selection is needed
  • @kandy : security threat from layout updates added through Admin UI is not clear. To discuss further with PO and security team
  • ✅ For now, value of the proposal is not clear. The discussion can be continued after clarifying questions with PO, if still relevant.