September 18, 2019 #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

lenaorobei opened this issue Sep 11, 2019 · 3 comments

Labels

Contributor

lenaorobei commented Sep 11, 2019 •

edited by buskamuza

Loading

Please add your topic as a comment to the issue. Use following format:
Topic description and link to PR, if any (duration in min)

Time: 10:30am CST/CDT

BlueJeans Meeting - https://bluejeans.com/7385677850

lenaorobei added the meeting notes label

lenaorobei mentioned this issue

MC-19366: Adds GraphQL sniffs magento/magento-coding-standard#141

Merged

Contributor

paliarush commented Sep 18, 2019

GraphQL custom attributes container #282 (10 min)

Contributor

buskamuza commented Sep 18, 2019

GraphQL custom attributes container
- @kandy : is it possible to limit list of returned attributes? @paliarush : all visible attributes will be returned, there is no way to limit further.
- @kandy : why "custom_attributes"? @paliarush : same name is used in REST.
- @akaplya : introduce type? @paliarush : talk to PWA team to clarify if it's necessary.
- @buskamuza : please add more details about scenarios being covered. How to distinguish attributes that should be displayed in product listing vs on product details page.
- @paliarush : should we include attribute metadata in the response? @akaplya : it's inefficient, because metadata can be cached separately.

Contributor

buskamuza commented Sep 18, 2019

Changes in product pricing GraphQL schema (Changes to Product pricing in schema #278)
- ✅ looks good

buskamuza closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment