Skip to content

Declarative Schema - Add OnUpdate operation for constraints #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ihor-sviziev opened this issue Oct 3, 2019 · 1 comment
Closed

Declarative Schema - Add OnUpdate operation for constraints #310

ihor-sviziev opened this issue Oct 3, 2019 · 1 comment

Comments

@ihor-sviziev
Copy link

ihor-sviziev commented Oct 3, 2019 •
edited
Loading

Following PR magento/magento2#24644 introducing new operator "onUpdate" in Declarative Schema.

As for me - looks really good improvement, but it has few issues:

  1. This PR adds backward incompatible change. As for me - it's good reason to add it, but it requires approval from Architects
  2. I'm not sure why on update wasn't added, maybe it could add some potential issues?
This was referenced Oct 3, 2019
Closed
Closed
@ihor-sviziev
Copy link
Author

We got an answer here: magento/magento2#24644 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ihor-sviziev