From 0dd285daca956bb2f9d1c9c44dfe886cf208498b Mon Sep 17 00:00:00 2001 From: Lena Orobei Date: Fri, 8 Nov 2019 15:12:12 -0600 Subject: [PATCH 1/2] updateCustomerV2 code style fixes --- .../graph-ql/coverage/customer-email-password-update.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/design-documents/graph-ql/coverage/customer-email-password-update.md b/design-documents/graph-ql/coverage/customer-email-password-update.md index 12f7a82e1..e24af223e 100644 --- a/design-documents/graph-ql/coverage/customer-email-password-update.md +++ b/design-documents/graph-ql/coverage/customer-email-password-update.md @@ -15,7 +15,7 @@ Deprecate `updateCustomer` mutation in favor of `updateCustomerV2`. `CustomerUpd ```graphql mutation { - updateCustomerV2(input: CustomerUpdateInput!): Customer + updateCustomerV2(input: CustomerUpdateInput!): CustomerOutput } type CustomerUpdateInput { @@ -36,7 +36,7 @@ Deprecate `updateCustomer` mutation in favor of `updateCustomerV2`. `CustomerUpd ```graphql mutation { - updateCustomerEmail(email: String!, password: String!): Customer + updateCustomerEmail(email: String!, password: String!): CustomerOutput } ``` @@ -44,7 +44,7 @@ Deprecate `updateCustomer` mutation in favor of `updateCustomerV2`. `CustomerUpd ```graphql mutation { - updateCustomerPassword(password: String!, old_password: String!): Customer + updateCustomerPassword(currentPassword: String!, newPassword: String!): CustomerOutput } ``` From 0d7a5a24558b49af0a1ef26abb0d06d03517530c Mon Sep 17 00:00:00 2001 From: Lena Orobei Date: Wed, 20 Nov 2019 10:21:20 -0600 Subject: [PATCH 2/2] Removed `updateCustomerPassword` because `changeCustomerPassword` mutation is already implemented --- .../coverage/customer-email-password-update.md | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/design-documents/graph-ql/coverage/customer-email-password-update.md b/design-documents/graph-ql/coverage/customer-email-password-update.md index e24af223e..bd31778dc 100644 --- a/design-documents/graph-ql/coverage/customer-email-password-update.md +++ b/design-documents/graph-ql/coverage/customer-email-password-update.md @@ -18,7 +18,7 @@ Deprecate `updateCustomer` mutation in favor of `updateCustomerV2`. `CustomerUpd updateCustomerV2(input: CustomerUpdateInput!): CustomerOutput } - type CustomerUpdateInput { + input CustomerUpdateInput { date_of_birth: String dob: String firstname: String @@ -39,15 +39,7 @@ Deprecate `updateCustomer` mutation in favor of `updateCustomerV2`. `CustomerUpd updateCustomerEmail(email: String!, password: String!): CustomerOutput } ``` - - **updateCustomerPassword** - - ```graphql - mutation { - updateCustomerPassword(currentPassword: String!, newPassword: String!): CustomerOutput - } - ``` - + ### Alternative solution Alternative solution is to use existing field consistently for setting new customer password and introduce additional input argument for current password verification: