Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Commit ae3544b

Browse files
authored
Merge pull request #5 from magento/master
Merge with upstream
2 parents 13be92b + abf7cd6 commit ae3544b

File tree

8,074 files changed

+386854
-489358
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

8,074 files changed

+386854
-489358
lines changed

.github/CODE_OF_CONDUCT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ further defined and clarified by project maintainers.
5555
## Enforcement
5656

5757
Instances of abusive, harassing, or otherwise unacceptable behavior may be
58-
reported by contacting the project team at DL-Magento-Doc-Feedback@magento.com. All
58+
reported by contacting the project team in [Slack](https://magentocommeng.slack.com/messages/CAN932A3H). All
5959
complaints will be reviewed and investigated and will result in a response that
6060
is deemed necessary and appropriate to the circumstances. The project team is
6161
obligated to maintain confidentiality with regard to the reporter of an incident.

.github/CONTRIBUTING.md

Lines changed: 23 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ Share your knowledge with the community by contributing to Magento DevDocs!
44
You can contribute by creating an issue or pull request (PR) on our [DevDocs](https://github.com/magento/devdocs) GitHub repository.
55
We welcome all types of contributions; from minor typo fixes to new topics.
66

7-
DevDocs staff members and [Community Maintainers](https://devdocs.magento.com/guides/v2.3/contributor-guide/contributors.html#/community-maintainers) review issues and pull requests on a regular basis. We do our best to address all issues as soon as possible, but working through the backlog takes time. We appreciate your patience.
7+
DevDocs staff members and [Community Maintainers](https://devdocs.magento.com/contributor-guide/contributors.html#/community-maintainers) review issues and pull requests on a regular basis. We do our best to address all issues as soon as possible, but working through the backlog takes time. We appreciate your patience.
88

99
## Rewards for contributions
1010

1111
DevDocs works with Magento Community Engineering teams and projects.
12-
As you contribute PRs, you gain [Contribution Points](https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing.html#points).
12+
As you contribute PRs, you gain [Contribution Points](https://devdocs.magento.com/contributor-guide/contributing.html#points).
1313

1414
If you write and contribute a full topic, we will add your name (or your company's name) at the top of the DevDocs page and link it to your blog or website!
1515

@@ -19,11 +19,13 @@ If you write and contribute a full topic, we will add your name (or your company
1919

2020
1. Make sure you have a [GitHub account](https://github.com/signup/free).
2121

22-
**Note for partners:** Add [2FA](https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing.html#two-factor) protection when contributing to Magento repositories.
22+
**Note for partners:** Add [2FA](https://devdocs.magento.com/contributor-guide/contributing.html#two-factor) protection when contributing to Magento repositories.
2323

2424
1. [Fork](https://help.github.com/articles/fork-a-repo/) the [DevDocs repository](https://github.com/magento/devdocs). Remember to [sync your fork](https://help.github.com/articles/syncing-a-fork/) and update branches as needed.
2525
1. Review the [DevDocs guidelines](#contribution-guidelines).
2626

27+
**Note:** If you use a fork instead of a branch, please set permissions to allow maintainers to edit and update the PR. See [Allowing changes to a pull request branch created from a fork](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork) in the _GitHub documentation_.
28+
2729
## Contribute documentation
2830

2931
The following diagram shows the contribution workflow:
@@ -44,15 +46,15 @@ The following diagram shows the contribution workflow:
4446

4547
In general, you should use `master` as the base branch when creating a PR. If your contribution is related to a release that is in progress, use a version-specific integration branch, such as `develop`.
4648

47-
1. Complete the pull request template.
49+
1. Complete the pull request template. Review the [Pull Request Process page](https://github.com/magento/devdocs/wiki/Pull-Request-Process) to learn how to complete a PR (with info about completing the template, adding a `whatsnew`, and more.)
4850

4951
**We will close your pull request if you do not complete the template.**
5052

5153
1. After creating a pull request, a DevDocs staff member or maintainer will review it and may ask you to make revisions.
5254

5355
**We will close your pull request if you do not respond to feedback in two weeks.**
5456

55-
**Note:** If you have not signed the [Magento Contributor Agreement](https://magento.com/content/magento-contributor-agreement), the pull request provides a link. Magento requires a signed form and agreement to the terms for contribution.
57+
**Note:** If you have not signed the [Adobe Contributor License Agreement](https://opensource.adobe.com/cla.html), the pull request provides a link. You must sign the CLA before we can accept your contribution.
5658

5759
## Contribution guidelines
5860

@@ -61,16 +63,19 @@ The following guidelines may answer most of your questions and help you get star
6163
- Write content using Markdown. See the [Templates](#templates) section for examples.
6264
- Review existing [pull requests](https://github.com/magento/devdocs/pulls) and [issues](https://github.com/magento/devdocs/issues) to avoid duplicating work.
6365
- For large contributions, or changes that include multiple files, [open an issue](#report-an-issue) and discuss it with us first. This helps prevent duplicate or unnecessary work.
64-
- Do not make global find-and-replace changes without first creating an issue and discussing it with us. Global changes can have unintended consequences.
66+
- Do not make global find-and-replace changes without first [creating an issue](https://github.com/magento/devdocs/issues/new/choose) and discussing it with us. Global changes can have unintended consequences.
67+
- Do not make changes to content in the [`_data/codebase`](https://github.com/magento/devdocs/tree/master/src/_data/codebase) directory, which contains auto-generated data from Magento source code. Any manual changes will be lost when the file regenerates.
6568
- Combine multiple small changes (such as minor editorial and technical changes) into a single pull request. This helps us efficiently and effectively facilitate your contribution.
6669
- Familiarize yourself with the organization and conventions of our existing documentation before creating a pull request. Changes that are consistent with our style and conventions have a higher acceptance rate.
6770

6871
- If you need to update the site navigation, ask for help in Slack ([#devdocs](https://magentocommeng.slack.com/messages/CAN932A3H)).
6972

70-
- Ensure that you update the correct version(s) of documentation (v2.2, v2.3). If you are not sure what directory to put your content in, just do your best. We can help re-locate it (if necessary) during the review process.
73+
- Ensure that you update the correct version(s) of documentation (v2.3). If you are not sure what directory to put your content in, just do your best. We can help re-locate it (if necessary) during the review process.
7174
- Review your work for basic typos, formatting errors, or ambiguous sentences before opening a pull request.
7275
- Revise pull requests according to review feedback. We will close pull requests that require an inordinate amount of time to review and process (especially for minor changes) if you fail to make revisions according to review feedback.
7376
- Do not directly contact DevDocs team members or maintainers on Slack to review your pull request unless it has been open for more than five days. We have a process and queue for pull requests that everyone must follow.
77+
- Get recognized on the DevDocs web site for writing new topics! Add your name and a link to your company website or GitHub profile to the file metadata so that we can display it on the page. See [Edit metadata](#edit-metadata).
78+
- We no longer recognize individual community members who contribute features to the Magento 2 codebase in the corresponding feature topic(s) on the DevDocs website. Magento recognizes these contributions in more appropriate channels (for example, the [Magento DevBlog](https://community.magento.com/t5/Magento-DevBlog/bg-p/devblog)).
7479

7580
## Tips for writing content
7681

@@ -94,21 +99,22 @@ _(Optional)_ To review your changes in HTML output, follow the instructions in t
9499

95100
We provide templates to help you get started writing new content and understanding Markdown formatting:
96101

97-
- **General topic template** - [Markdown](https://github.com/magento/devdocs/blob/master/guides/v2.3/contributor-guide/templates/basic_template.md) | [HTML](https://devdocs.magento.com/guides/v2.3/contributor-guide/templates/basic_template.html): This is a template for writing any topic with example formats and styles.
102+
- **General topic template** - [Markdown](https://github.com/magento/devdocs/blob/master/contributor-guide/templates/basic_template.md) | [HTML](https://devdocs.magento.com/contributor-guide/templates/basic_template.html): This is a template for writing any topic with example formats and styles.
98103
- **Tutorial templates**: These templates provide example formats and styles for step-by-step instructions (like how-tos). Each file adds navigation buttons when content is generated. Templates include:
99-
- First introduction topic - [Markdown](https://github.com/magento/devdocs/blob/master/guides/v2.3/contributor-guide/templates/tutorial-template-first.md) | [HTML](https://devdocs.magento.com/guides/v2.3/contributor-guide/templates/tutorial-template-first.html): Introduction to a tutorial for prerequisites and listing steps
100-
- Middle topic - [Markdown](https://github.com/magento/devdocs/blob/master/guides/v2.3/contributor-guide/templates/tutorial-template-middle.md) | [HTML](https://devdocs.magento.com/guides/v2.3/contributor-guide/templates/tutorial-template-middle.html): Use for each step in a tutorial.
101-
- Final step topic - [Markdown](https://github.com/magento/devdocs/blob/master/guides/v2.3/contributor-guide/templates/tutorial-template-last.md) | [HTML](https://devdocs.magento.com/guides/v2.3/contributor-guide/templates/tutorial-template-last.html): Use for the last step of the tutorial.
104+
- First introduction topic - [Markdown](https://github.com/magento/devdocs/blob/master/contributor-guide/templates/tutorial-template-first.md) | [HTML](https://devdocs.magento.com/contributor-guide/templates/tutorial-template-first.html): Introduction to a tutorial for prerequisites and listing steps
105+
- Middle topic - [Markdown](https://github.com/magento/devdocs/blob/master/contributor-guide/templates/tutorial-template-middle.md) | [HTML](https://devdocs.magento.com/contributor-guide/templates/tutorial-template-middle.html): Use for each step in a tutorial.
106+
- Final step topic - [Markdown](https://github.com/magento/devdocs/blob/master/contributor-guide/templates/tutorial-template-last.md) | [HTML](https://devdocs.magento.com/contributor-guide/templates/tutorial-template-last.html): Use for the last step of the tutorial.
102107

103108
### Edit metadata
104109

105-
The Markdown (.md) file's metadata is a set of YAML key-value pairs. The metadata section is located at the top of each file. For more info, see the [Basic Template](https://devdocs.magento.com/guides/v2.3/contributor-guide/templates/basic_template.html).
110+
The Markdown (.md) file's metadata is a set of YAML key-value pairs. The metadata section is located at the top of each file. For more info, see the [Basic Template](https://devdocs.magento.com/contributor-guide/templates/basic_template.html).
106111

107112
```yaml
108-
109113
---
110-
group: install2
111-
title: Continue with your installation
114+
group:
115+
title:
116+
contributor_name:
117+
contributor_link:
112118
---
113119
```
114120

@@ -118,45 +124,8 @@ title: Continue with your installation
118124
| ------------- | ---------- |
119125
| `group` | Defines the topic's guide or section. Use the table of contents `.yml` file name. This loads your left-side navigation. We will help during the PR process to add new files to the `.yml` file. |
120126
| `title` | Sets the title of the page in the HTML metadata and the main title on the page. |
121-
122-
## Symbolic links
123-
124-
We use symbolic links for topics that are the same across versions of Magento. A file is symlinked if the entire content of the file is a path to the original version, such as [ext-best-practices/tutorials/serialized-to-json-data-upgrade.md](https://github.com/magento/devdocs/blob/master/guides/v2.3/ext-best-practices/tutorials/serialized-to-json-data-upgrade.md). Note that some editors will automatically follow symlinks so it might not be clear if a file is symlinked or not. Check the file on Github directly to be sure.
125-
126-
### Create a symbolic link
127-
128-
When you create a new topic (create a new `.md` file) and its content is the same for 2.2 and 2.3 versions, create a symbolic link.
129-
130-
For example, if you created a new file for v.2.2---`guides/v2.2/install-gde/new-doc-topic.md`---and its content is the same for v.2.3, use the command below to create the symbolic link.
131-
132-
```bash
133-
cd <DEVDOCS_REPOSITORY_ROOT_DIR>
134-
```
135-
136-
```bash
137-
ln -s guides/v2.2/install-gde/new-doc-topic.md guides/v2.3/install-gde/new-doc-topic.md
138-
```
139-
140-
If you have an image that is identical between versions, it should placed in `/common/images`. Please optimize images before committing them to the repository.
141-
If done correctly, the symbolic link path will start with 3 or 4 instances of `../`, as the above example shows.
142-
143-
### Remove a symbolic link
144-
145-
If your changes are unique to a specific version, remove the symbolic link and add a new file. Copy and paste a previous version of the topic to get started.
146-
147-
The removal should use the `git rm` command specifically. Deleting the file through the regular file system might cause issues with the repository.
148-
149-
For example:
150-
151-
```bash
152-
git rm guides/v2.3/install-gde/composer.md
153-
```
154-
155-
```bash
156-
cp guides/v2.2/install-gde/composer.md guides/v2.3/install-gde/composer.md
157-
```
158-
159-
Once you have the copy in place, you can edit it with the version-specific information.
127+
| `contributor_name` | Sets the name of the contributor who wrote the topic and displays it on the page. |
128+
| `contributor_link` | Creates a link to the contributor's GitHub profile or company website. |
160129

161130
## Report an issue
162131

@@ -181,6 +150,5 @@ Have a question? Need help? Magento DevDocs, Maintainers, and other Contributors
181150

182151
- [Slack](https://magentocommeng.slack.com/messages/CAN932A3H) ([Join us](http://tinyurl.com/engcom-slack))
183152
- [Twitter @MagentoDevDocs](https://twitter.com/MagentoDevDocs)
184-
- [E-mail](mailto:[email protected])
185153

186154
Thank you for contributing your brilliance to Magento DevDocs!!

.github/ISSUE_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Thank you for taking the time to report this issue!
1717
GitHub Issues should only be created for problems/topics related to this project's codebase.
1818
1919
Before submitting this issue, please make sure you are complying with our Code of Conduct:
20-
https://github.com/magento/devdocs/blob/develop/.github/CODE_OF_CONDUCT.md
20+
https://github.com/magento/devdocs/blob/master/.github/CODE_OF_CONDUCT.md
2121
2222
Issues that do not comply with our Code of Conduct or do not contain enough information may be closed at the maintainers' discretion.
2323

.github/ISSUE_TEMPLATE/BUG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Thank you for taking the time to report this issue!
3434
GitHub Issues should only be created for problems/topics related to this project's codebase.
3535
3636
Before submitting this issue, please make sure you are complying with our Code of Conduct:
37-
https://github.com/magento/devdocs/blob/develop/.github/CODE_OF_CONDUCT.md
37+
https://github.com/magento/devdocs/blob/master/.github/CODE_OF_CONDUCT.md
3838
3939
Issues that do not comply with our Code of Conduct or do not contain enough information may be closed at the maintainers' discretion.
4040

.github/ISSUE_TEMPLATE/COMMUNITY_ISSUE_TEMPLATE.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,7 @@ Magento 2 GitHub PR: https://github.com/magento/devdocs/pull/link
1919

2020
Magento 2 version:
2121

22-
- [ ] 2.1.X
23-
- [ ] 2.2.X
24-
- [ ] 2.3.X
25-
- [ ] back port
26-
- [ ] forward port
22+
- [ ] 2.3
2723

2824
Notifications of Changes:
2925

@@ -45,7 +41,7 @@ Thank you for taking the time to request updates for your Community Engineering
4541
GitHub Issues should only be created for problems/topics related to this project's codebase.
4642
4743
Before submitting this issue, please make sure you are complying with our Code of Conduct:
48-
https://github.com/magento/devdocs/blob/develop/.github/CODE_OF_CONDUCT.md
44+
https://github.com/magento/devdocs/blob/master/.github/CODE_OF_CONDUCT.md
4945
5046
Issues that do not comply with our Code of Conduct or do not contain enough information may be closed at the maintainers' discretion.
5147

.github/ISSUE_TEMPLATE/NEW_FEATURE.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,9 @@ Thank you for taking the time to report this issue!
3030
GitHub Issues should only be created for problems/topics related to this project's codebase.
3131
3232
Before submitting this issue, please make sure you are complying with our Code of Conduct:
33-
https://github.com/magento/devdocs/blob/develop/.github/CODE_OF_CONDUCT.md
33+
https://github.com/magento/devdocs/blob/master/.github/CODE_OF_CONDUCT.md
3434
3535
Issues that do not comply with our Code of Conduct or do not contain enough information may be closed at the maintainers' discretion.
3636
3737
Feel free to remove this section before creating this issue.
3838
-->
39-

.github/ISSUE_TEMPLATE/NEW_TOPIC.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Thank you for taking the time to report this issue!
2929
GitHub Issues should only be created for problems/topics related to this project's codebase.
3030
3131
Before submitting this issue, please make sure you are complying with our Code of Conduct:
32-
https://github.com/magento/devdocs/blob/develop/.github/CODE_OF_CONDUCT.md
32+
https://github.com/magento/devdocs/blob/master/.github/CODE_OF_CONDUCT.md
3333
3434
Issues that do not comply with our Code of Conduct or do not contain enough information may be closed at the maintainers' discretion.
3535

.github/ISSUE_TEMPLATE/TOPIC_CLARIFICATION.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Thank you for taking the time to report this issue!
2626
GitHub Issues should only be created for problems/topics related to this project's codebase.
2727
2828
Before submitting this issue, please make sure you are complying with our Code of Conduct:
29-
https://github.com/magento/devdocs/blob/develop/.github/CODE_OF_CONDUCT.md
29+
https://github.com/magento/devdocs/blob/master/.github/CODE_OF_CONDUCT.md
3030
3131
Issues that do not comply with our Code of Conduct or do not contain enough information may be closed at the maintainers' discretion.
3232

0 commit comments

Comments
 (0)