Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Test coverage: GetAvailableShippingMethodsTest #428

Closed
naydav opened this issue Mar 4, 2019 · 1 comment
Closed

Test coverage: GetAvailableShippingMethodsTest #428

naydav opened this issue Mar 4, 2019 · 1 comment
Assignees
@atwixfirster
Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage
Milestone
Release: 2.3.2

Comments

@naydav
Copy link
Contributor

naydav commented Mar 4, 2019

  1. Need to split \Magento\GraphQl\Quote\GetAvailableShippingMethodsTest
    into 2 scenarions
- \Magento\GraphQl\Quote\Customer\GetAvailableShippingMethodsTest
- \Magento\GraphQl\Quote\Guest\GetAvailableShippingMethodsTest
  1. Need to add negative cases (like try to get access to cart if a customer is not an owner)
    Examples you could find in
    https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer

https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest
@naydav naydav added good first issue Good for newcomers test-coverage Contribution Day Tickets is good for start on Contribution Day labels Mar 4, 2019
@naydav naydav added this to the Release: 2.3.2 milestone Mar 4, 2019
@atwixfirster atwixfirster self-assigned this Mar 13, 2019
@atwixfirster atwixfirster mentioned this issue Mar 13, 2019
Merged
@naydav
Copy link
Contributor Author

naydav commented Mar 30, 2019

#472

@naydav naydav closed this as completed Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@atwixfirster atwixfirster

Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage
Projects
None yet
Milestone
Release: 2.3.2
Development

No branches or pull requests
2 participants
@naydav @atwixfirster