Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Efficient Data Retrieval Framework for Category Queries #567

Closed
nrkapoor opened this issue Apr 4, 2019 · 1 comment
Closed

Efficient Data Retrieval Framework for Category Queries #567

nrkapoor opened this issue Apr 4, 2019 · 1 comment
Labels
epic magento-core Epics and issues assigned to Magento core team members.

Comments

@nrkapoor
Copy link

nrkapoor commented Apr 4, 2019

As a developer,
I want to optimize the graphql data retrieval framework for category queries
so that
I can improve the response times at scale.

Every query optimization must follow the following steps.

Deploy the existing version on cloud starter.
Run Blazemeter perf test for the query with 50 concurrent users.
Optimize the data retrieval framework for the query.
Deploy the changes to cloud starter.
Rerun the perf test in step 2 again and document the findings.
Merge the changes to mainline and deploy to cloud pro.
Run the perf test on cloud pro with 5000 concurrent users.

@nrkapoor nrkapoor added this to the Release: 2.3.2 - Core milestone Apr 4, 2019
@nrkapoor nrkapoor added magento-core Epics and issues assigned to Magento core team members. epic labels Apr 4, 2019
@naydav
Copy link
Contributor

naydav commented May 3, 2019

@nrkapoor
Please, review the description from initial ticket

The category query should include a filter argument, similar to the products query. It should achieve parity with the REST API's search criteria functionality on category entities.

AC

  • User is able to filter categories by
    • id
    • name
    • description
    • isAnchor: return only categories that are isAnchor=yes or isAnchor=no
    • level: return only categories that are on the specified level in the tree
    • parentId: return only direct children of the specified parent category
  • Endpoint accepts new filter criteria, and returns an array of matching CategoryTree objects

References:

Expected result

  1. It is possible to filter categories based on filterable attributes in a category query.
  2. Functionality is covered by automated api-functional tests. See \Magento\GraphQl\Catalog\ProductViewTest::testQueryAllFieldsSimpleProduct as an example.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
epic magento-core Epics and issues assigned to Magento core team members.
Projects
None yet
Development

No branches or pull requests

3 participants