Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Schema inconsistency in 'setBillingAddressOnCart', 'setShippingAddressesOnCart', 'CartAddress' declaration #592

Closed
TomashKhamlai opened this issue Apr 11, 2019 · 1 comment
Closed

Schema inconsistency in 'setBillingAddressOnCart', 'setShippingAddressesOnCart', 'CartAddress' declaration #592

TomashKhamlai opened this issue Apr 11, 2019 · 1 comment
Assignees
@naydav
Labels
Component: QuoteGraphQl

Comments

@TomashKhamlai
Copy link
Contributor

TomashKhamlai commented Apr 11, 2019 •
edited by naydav
Loading

CartAddressInput.region for setBillingAddressOnCart/setShippingAddressesOnCart is expected to be type of Int! and should have name region_id or should have similar meaning as CustomerAddress.region_id
and
CartAddress.region is expected to be similar to CustomerAddressRegion
@TomashKhamlai TomashKhamlai added bug Something isn't working Component: QuoteGraphQl labels Apr 11, 2019
This was referenced Apr 11, 2019
Closed
Closed
@naydav naydav added the Contribution Day Tickets is good for start on Contribution Day label Apr 22, 2019
@naydav naydav removed their assignment Apr 22, 2019
@TomashKhamlai TomashKhamlai mentioned this issue Apr 24, 2019
Closed
@naydav naydav changed the title Refactoring of 'setBillingAddressOnCart', 'setShippingAddressesOnCart', 'CartAddress' Inconsistency in 'setBillingAddressOnCart', 'setShippingAddressesOnCart', 'CartAddress' scheme Apr 24, 2019
@naydav naydav changed the title Inconsistency in 'setBillingAddressOnCart', 'setShippingAddressesOnCart', 'CartAddress' scheme Schema inconsistency in 'setBillingAddressOnCart', 'setShippingAddressesOnCart', 'CartAddress' declaration Apr 24, 2019
@naydav naydav self-assigned this Apr 24, 2019
@naydav naydav removed bug Something isn't working Contribution Day Tickets is good for start on Contribution Day labels Apr 24, 2019
@naydav
Copy link
Contributor

naydav commented Apr 24, 2019

Closed due to splitting work in
#627

@naydav naydav closed this as completed Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@naydav naydav

Labels
Component: QuoteGraphQl
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@naydav @TomashKhamlai