Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

[Customer] Deprecate customer_id in CustomerAddress #907

Closed
paliarush opened this issue Sep 5, 2019 · 0 comments
Closed

[Customer] Deprecate customer_id in CustomerAddress #907

paliarush opened this issue Sep 5, 2019 · 0 comments
Labels
Architects: approved Issue is checked and approved by architecture team. Component: CustomerGraphQl good first issue Good for newcomers

Comments

@paliarush
Copy link
Contributor

paliarush commented Sep 5, 2019

  1. customer_id is not needed as part of CustomerAddress, address ID (id) is unique identifier for the addresses
  2. id is not needed as part of Customer because on server side it can be identified based on customer token used for authentication. There is no need to know customer ID on the client side.

Acceptance criteria:

  • remove customer_id from CustomerAddress and id from Customer. Run web API tests to see if they stay green. Recover customer_id and id
  • deprecate customer_id in CustomerAddress and id in Customer
  • deprecated fields must return null all the time
@paliarush paliarush changed the title [Customer Account] Deprecate customer_id in CustomerAddress [Customer] Deprecate customer_id in CustomerAddress Sep 5, 2019
@kisroman kisroman self-assigned this Sep 16, 2019
@lenaorobei lenaorobei added this to the Release: 2.3.4 milestone Sep 17, 2019
@lenaorobei lenaorobei added the Architects: approved Issue is checked and approved by architecture team. label Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Architects: approved Issue is checked and approved by architecture team. Component: CustomerGraphQl good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants