Skip to content

Provide robust fix for nested object instantiation via Web API #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maghamed opened this issue Aug 2, 2018 · 2 comments
Closed

Provide robust fix for nested object instantiation via Web API #1537

maghamed opened this issue Aug 2, 2018 · 2 comments
Assignees
@phoenix128
Labels
Award: special achievement WEB API MSI web API failures and fixes
Milestone
MSI Part III

Comments

@maghamed
Copy link
Contributor

maghamed commented Aug 2, 2018

Initial fix delivered for #1524
but the root cause of the problem is @phoenix128 PR with the instantiation of DTOs without setters
@maghamed maghamed added this to the MSI Part II milestone Aug 2, 2018
@maghamed maghamed mentioned this issue Aug 2, 2018
Merged
@maghamed maghamed added the WEB API MSI web API failures and fixes label Aug 2, 2018
@phoenix128 phoenix128 self-assigned this Aug 2, 2018
This was referenced Aug 6, 2018
Closed
Closed
@phoenix128
Copy link
Contributor

Fixed by #1546 .

@phoenix128 phoenix128 mentioned this issue Aug 7, 2018
Merged
4 tasks
@maghamed maghamed mentioned this issue Oct 7, 2018
Closed
4 tasks
@maghamed maghamed modified the milestones: MSI Part II, MSI Part III Nov 16, 2018
@ishakhsuvarov
Copy link
Contributor

Merged in magento/magento2#17424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phoenix128 phoenix128

Labels
Award: special achievement WEB API MSI web API failures and fixes
Projects
None yet
Milestone
MSI Part III
Development

No branches or pull requests
3 participants
@maghamed @ishakhsuvarov @phoenix128