Skip to content

Commit b421a21

Browse files
committed
ACP2E-2977: Implement Static test which will check for no usage of object manager in .phtml files
1 parent 8850ff7 commit b421a21

File tree

3 files changed

+5
-30
lines changed

3 files changed

+5
-30
lines changed

Magento2/Sniffs/Templates/ObjectManagerSniff.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
* @link https://developer.adobe.com/commerce/frontend-core/guide/layouts/xml-instructions/#obtain-arguments-examples-in-template
3030
* @link https://developer.adobe.com/commerce/frontend-core/guide/templates/override/#getting-argument-values-from-layout
3131
*/
32-
class PhtmlTemplateObjectManagerSniff implements Sniff
32+
class ObjectManagerSniff implements Sniff
3333
{
3434
private const WARNING_CODE_OBJECT_MANAGER_USAGE = 'ObjectManagerUsageFound';
3535

Magento2/Tests/Templates/ObjectManager.1.phtml

Lines changed: 0 additions & 25 deletions
This file was deleted.

Magento2/Tests/Templates/ObjectManagerUnitTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,20 @@
1616
*/
1717
declare(strict_types = 1);
1818

19-
namespace Magento2\Tests\Phtml;
19+
namespace Magento2\Tests\Templates;
2020

2121
use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
2222

23-
class PhtmlTemplateObjectManagerUnitTest extends AbstractSniffUnitTest
23+
class ObjectManagerUnitTest extends AbstractSniffUnitTest
2424
{
2525
/**
2626
* @inheritdoc
2727
*/
2828
public function getWarningList($filename = '')
2929
{
30-
if ($filename === 'PhtmlTemplateObjectManager.1.phtml.inc') {
30+
if ($filename === 'ObjectManager.1.phtml.inc') {
3131
return [
32-
7 => 1
32+
18 => 1
3333
];
3434
}
3535
return [];

0 commit comments

Comments
 (0)