@author is actually ok

udovicic · udovicic · commit bbe068db755d · 2019-08-07T21:08:51.000+02:00
diff --git a/Magento2/Sniffs/Commenting/ClassAndInterfacePHPDocFormattingSniff.php b/Magento2/Sniffs/Commenting/ClassAndInterfacePHPDocFormattingSniff.php
@@ -22,8 +22,7 @@ class ClassAndInterfacePHPDocFormattingSniff implements Sniff
     /**
      * @var string[] List of tags that can not be used in comments
      */
-    private $forbiddenTags = [
-        '@author',
+    public $forbiddenTags = [
         '@category',
         '@package',
         '@subpackage'
diff --git a/Magento2/Tests/Commenting/ClassAndInterfacePHPDocFormattingUnitTest.1.inc b/Magento2/Tests/Commenting/ClassAndInterfacePHPDocFormattingUnitTest.1.inc
@@ -59,7 +59,7 @@ class EmptyHandler
  *
  * @api is ok here
  * @deprecated can be used in this context
- * @author must not be mentioned
+ * @author is actually ok
  * @category is irrelevant
  * @package is not ment to be used
  * @subpackage does not belong here
diff --git a/Magento2/Tests/Commenting/ClassAndInterfacePHPDocFormattingUnitTest.2.inc b/Magento2/Tests/Commenting/ClassAndInterfacePHPDocFormattingUnitTest.2.inc
@@ -59,7 +59,7 @@ interface EmptyHandler
  *
  * @api is ok here
  * @deprecated can be used in this context
- * @author must not be mentioned
+ * @author is actually ok
  * @category is irrelevant
  * @package is not ment to be used
  * @subpackage does not belong here
diff --git a/Magento2/Tests/Commenting/ClassAndInterfacePHPDocFormattingUnitTest.php b/Magento2/Tests/Commenting/ClassAndInterfacePHPDocFormattingUnitTest.php
@@ -32,7 +32,6 @@ public function getWarningList($testFile = '')
             35 => 1,
             44 => 1,
             52 => 1,
-            62 => 1,
             63 => 1,
             64 => 1,
             65 => 1,

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ class EmptyHandler`
`59`	`59`	`*`
`60`	`60`	`* @api is ok here`
`61`	`61`	`* @deprecated can be used in this context`
`62`		`- * @author must not be mentioned`
	`62`	`+ * @author is actually ok`
`63`	`63`	`* @category is irrelevant`
`64`	`64`	`* @package is not ment to be used`
`65`	`65`	`* @subpackage does not belong here`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ interface EmptyHandler`
`59`	`59`	`*`
`60`	`60`	`* @api is ok here`
`61`	`61`	`* @deprecated can be used in this context`
`62`		`- * @author must not be mentioned`
	`62`	`+ * @author is actually ok`
`63`	`63`	`* @category is irrelevant`
`64`	`64`	`* @package is not ment to be used`
`65`	`65`	`* @subpackage does not belong here`
-Original file line number
+Diff line change
 => 1,
 => 1,
 => 1,
 -            62 => 1,
 => 1,
 => 1,
 => 1,