Update implementation

Author: Lars Roettig

Magento2/Sniffs/Performance/ForeachArrayMergeSniff.php

@@ -62,6 +62,7 @@ public function process(File $phpcsFile, $stackPtr)
                 continue;
             }
 
+            $this->foreachCache[$cacheKey] = '';
             $phpcsFile->addWarning($this->warningMessage, $i, $this->warningCode);
         }
     }

Magento2/Tests/Performance/ForeachArrayMergeUnitTest.inc

@@ -19,16 +19,25 @@ for ($i = 0; $i <= $itemCount; $i++) {
     $options = array_merge($options, $source));
 }
 
-class CSV
+class SelectBuilder
 {
-    public static function getColumns()
+    private $columns = [];
+
+    public function getColumns()
     {
-        return [];
+        return $this->columns;
+    }
+
+    public function setColumns(array $columns)
+    {
+        $this->columns = $columns;
     }
 }
 
+$selectBuilder = new SelectBuilder();
+
 foreach ([] as $collection) {
     foreach ($configurationSources as $source) {
-        $options = array_merge(CSV::getColumns(), $source);
+        $selectBuilder->setColumns(array_merge($selectBuilder->getColumns(), $source));
     }
 }

Magento2/Tests/Performance/ForeachArrayMergeUnitTest.php

@@ -27,7 +27,7 @@ public function getWarningList()
     {
         return [
             11 => 1,
-            19 => 1,
+            19 => 1
         ];
     }
 }