Skip to content

Go back to semantic versioning #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Nov 7, 2019 · 3 comments
Closed

Go back to semantic versioning #158

ghost opened this issue Nov 7, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Nov 7, 2019

Since version 3, semantic versioning has been disregarded.

Is there a specific reason for this?

@ghost ghost added the bug Something isn't working label Nov 7, 2019
@FreekVandeursen
Copy link

See: magento/architecture#136

@lazyguru
Copy link

lazyguru commented Nov 7, 2019

+1 on this. You are breaking builds by frequently introducing what are effectively BC breaks. There should be version numbers that are then enforced with Marketplace at scheduled intervals (eg, "We recommend you adhere to version 5 but will continue to only enforce version 4 until X date"). With the current solution it's possible that the rules could get changed between the time a package is generated and when it is submitted to the Marketplace. It's great that you want to adhere to the latest standard in core, but that doesn't scale when applied to all partners and extension developers without warning.

@lenaorobei
Copy link
Contributor

Hi @paul-gene! Yes, as @FreekVandeursen mentioned there was a long thread of discussion regarding coding standard versioning.

Semantic version makes sense if we were going to support multiple release lines, for example 1.0.0, then 2.1.0 and patch to 1.0.1, but we don't. This change is the result of the decision that only one (latest) version of coding standard will be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants