graphQl-784: optimized the code

Vitaliy Boyko · Vitaliy Boyko · commit 03949568f3de · 2019-07-25T21:58:35.000+03:00
diff --git a/app/code/Magento/QuoteGraphQl/Model/Cart/QuoteAddressFactory.php b/app/code/Magento/QuoteGraphQl/Model/Cart/QuoteAddressFactory.php
@@ -60,10 +60,11 @@ public function __construct(
      */
     public function createBasedOnInputData(array $addressInput): QuoteAddress
     {
+        $addressInput['country_id'] = '';
         if ($addressInput['country_code']) {
             $addressInput['country_code'] = strtoupper($addressInput['country_code']);
         }
-        $addressInput['country_id'] = $addressInput['country_code'] ?? '';
+        $addressInput['country_id'] = $addressInput['country_code'];
 
         $maxAllowedLineCount = $this->addressHelper->getStreetLines();
         if (is_array($addressInput['street']) && count($addressInput['street']) > $maxAllowedLineCount) {

Original file line number	Diff line number	Diff line change
`@@ -60,10 +60,11 @@ public function __construct(`
`60`	`60`	`*/`
`61`	`61`	`public function createBasedOnInputData(array $addressInput): QuoteAddress`
`62`	`62`	`{`
	`63`	`+ $addressInput['country_id'] = '';`
`63`	`64`	`if ($addressInput['country_code']) {`
`64`	`65`	`$addressInput['country_code'] = strtoupper($addressInput['country_code']);`
`65`	`66`	`}`
`66`		`- $addressInput['country_id'] = $addressInput['country_code'] ?? '';`
	`67`	`+ $addressInput['country_id'] = $addressInput['country_code'];`
`67`	`68`
`68`	`69`	`$maxAllowedLineCount = $this->addressHelper->getStreetLines();`
`69`	`70`	`if (is_array($addressInput['street']) && count($addressInput['street']) > $maxAllowedLineCount) {`