Merge pull request #8356 from magento-performance/application-server

GraphQl. Reset mutable state after request

Author: andimov

app/code/Magento/Backup/Model/Fs/Collection.php

@@ -29,8 +29,6 @@ class Collection extends \Magento\Framework\Data\Collection\Filesystem
     protected $_path = 'backups';
 
     /**
-     * Backup data
-     *
      * @var \Magento\Backup\Helper\Data
      */
     protected $_backupData = null;
@@ -46,7 +44,9 @@ class Collection extends \Magento\Framework\Data\Collection\Filesystem
      * @var \Magento\Framework\Filesystem
      */
     private $_filesystem;
+
     /**
+     *
      * @param \Magento\Framework\Data\Collection\EntityFactory $entityFactory
      * @param \Magento\Backup\Helper\Data $backupData
      * @param \Magento\Framework\Filesystem $filesystem
@@ -61,21 +61,26 @@ public function __construct(
     ) {
         $this->_backupData = $backupData;
         parent::__construct($entityFactory, $filesystem);
-
         $this->_filesystem = $filesystem;
         $this->_backup = $backup;
         $this->_varDirectory = $filesystem->getDirectoryWrite(DirectoryList::VAR_DIR);
-
         $this->_hideBackupsForApache();
+        $this->initialize();
+    }
 
+    /**
+     * Initialize collection
+     *
+     * @return void
+     */
+    private function initialize()
+    {
         // set collection specific params
         $extensions = $this->_backupData->getExtensions();
-
         foreach ($extensions as $value) {
             $extensions[] = '(' . preg_quote($value, '/') . ')';
         }
         $extensions = implode('|', $extensions);
-
         $this->_varDirectory->create($this->_path);
         $path = rtrim($this->_varDirectory->getAbsolutePath($this->_path), '/') . '/';
         $this->setOrder(
@@ -90,6 +95,15 @@ public function __construct(
         );
     }
 
+    /**
+     * @inheritDoc
+     */
+    public function _resetState(): void
+    {
+        parent::_resetState();
+        $this->initialize();
+    }
+
     /**
      * Create .htaccess file and deny backups directory access from web
      *

app/code/Magento/Bundle/Pricing/Adjustment/DefaultSelectionPriceListProvider.php

@@ -255,6 +255,6 @@ private function getBundleOptions(Product $saleableItem)
      */
     public function _resetState(): void
     {
-        $this->priceList = [];
+        $this->priceList = null;
     }
 }

app/code/Magento/BundleImportExport/Model/Import/Product/Type/Bundle.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\BundleImportExport\Model\Import\Product\Type;
 
@@ -783,7 +784,7 @@ private function getStoreIdByCode(string $storeCode): int
         if (!isset($this->storeCodeToId[$storeCode])) {
             /** @var $store Store */
             foreach ($this->storeManager->getStores() as $store) {
-                $this->storeCodeToId[$store->getCode()] = $store->getId();
+                $this->storeCodeToId[$store->getCode()] = (int)$store->getId();
             }
         }
 

app/code/Magento/Catalog/Helper/Product/Flat/Indexer.php

@@ -6,6 +6,7 @@
 namespace Magento\Catalog\Helper\Product\Flat;
 
 use Magento\Framework\App\ResourceConnection;
+use Magento\Framework\ObjectManager\ResetAfterRequestInterface;
 
 /**
  * Catalog Product Flat Indexer Helper
@@ -15,17 +16,17 @@
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  * @since 100.0.2
  */
-class Indexer extends \Magento\Framework\App\Helper\AbstractHelper
+class Indexer extends \Magento\Framework\App\Helper\AbstractHelper implements ResetAfterRequestInterface
 {
     /**
      * Path to list of attributes used for flat indexer
      */
-    const XML_NODE_ATTRIBUTE_NODES = 'global/catalog/product/flat/attribute_groups';
+    public const XML_NODE_ATTRIBUTE_NODES = 'global/catalog/product/flat/attribute_groups';
 
     /**
      * Size of ids batch for reindex
      */
-    const BATCH_SIZE = 500;
+    public const BATCH_SIZE = 500;
 
     /**
      * Resource instance
@@ -49,7 +50,7 @@ class Indexer extends \Magento\Framework\App\Helper\AbstractHelper
     /**
      * Retrieve catalog product flat columns array in old format (used before MMDB support)
      *
-     * @return array
+     * @var array
      */
     protected $_attributes;
 
@@ -93,8 +94,6 @@ class Indexer extends \Magento\Framework\App\Helper\AbstractHelper
     protected $_flatAttributeGroups = [];
 
     /**
-     * Config factory
-     *
      * @var \Magento\Catalog\Model\ResourceModel\ConfigFactory
      */
     protected $_configFactory;
@@ -256,6 +255,7 @@ public function getFlatColumns()
                     $this->isAddChildData()
                 )->getFlatColumns();
                 if ($columns !== null) {
+                    // phpcs:ignore Magento2.Performance.ForeachArrayMerge
                     $this->_columns = array_merge($this->_columns, $columns);
                 }
             }
@@ -332,6 +332,7 @@ public function getAttributeCodes()
 
             foreach ($this->_flatAttributeGroups as $attributeGroupName) {
                 $attributes = $this->_attributeConfig->getAttributeNames($attributeGroupName);
+                // phpcs:ignore Magento2.Performance.ForeachArrayMerge
                 $this->_systemAttributes = array_unique(array_merge($attributes, $this->_systemAttributes));
             }
 
@@ -416,6 +417,7 @@ public function getFlatIndexes()
                     $this->isAddChildData()
                 )->getFlatIndexes();
                 if ($indexes !== null) {
+                    // phpcs:ignore Magento2.Performance.ForeachArrayMerge
                     $this->_indexes = array_merge($this->_indexes, $indexes);
                 }
             }
@@ -515,4 +517,13 @@ public function deleteAbandonedStoreFlatTables()
             $connection->dropTable($table);
         }
     }
+
+    /**
+     * @inheritDoc
+     */
+    public function _resetState(): void
+    {
+        $this->_entityTypeId = null;
+        $this->_flatAttributeGroups = [];
+    }
 }

app/code/Magento/Catalog/Model/CategoryRepository/PopulateWithValues.php

@@ -157,6 +157,6 @@ private function getAttributes(): array
      */
     public function _resetState(): void
     {
-        $this->attributes = [];
+        $this->attributes = null;
     }
 }

app/code/Magento/Catalog/Model/Config.php

@@ -89,11 +89,6 @@ class Config extends \Magento\Eav\Model\Config
      */
     protected $_eavConfig;
 
-    /**
-     * @var \Magento\Store\Model\StoreManagerInterface
-     */
-    protected $_storeManager;
-
     /**
      * @var \Magento\Eav\Model\ResourceModel\Entity\Attribute\Set\CollectionFactory
      */
@@ -166,7 +161,8 @@ public function __construct(
             $universalFactory,
             $serializer,
             $scopeConfig,
-            $attributesForPreload
+            $attributesForPreload,
+            $storeManager,
         );
     }
 

app/code/Magento/Catalog/Model/Product.php

@@ -2840,7 +2840,7 @@ public function _resetState(): void
     {
         $this->_customOptions = [];
         $this->_errors = [];
-        $this->_canAffectOptions = [];
+        $this->_canAffectOptions = false;
         $this->_productIdCached = null;
     }
 }

app/code/Magento/Catalog/Model/ResourceModel/Collection/AbstractCollection.php

@@ -81,8 +81,8 @@ public function __construct(
      */
     public function _resetState(): void
     {
-        parent::_resetState();
         $this->_storeId = null;
+        parent::_resetState();
     }
 
     /**

app/code/Magento/Catalog/Model/ResourceModel/Product/Collection.php

@@ -397,7 +397,6 @@ public function __construct(
      */
     public function _resetState(): void
     {
-        parent::_resetState();
         $this->_flatEnabled = [];
         $this->_addUrlRewrite = false;
         $this->_urlRewriteCategory = '';
@@ -419,7 +418,7 @@ public function _resetState(): void
         $this->linkField = null;
         $this->backend = null;
         $this->emptyItem = null;
-        $this->_construct();
+        parent::_resetState();
     }
 
     /**

app/code/Magento/CatalogSearch/Model/ResourceModel/Fulltext/Collection.php

@@ -224,13 +224,13 @@ public function __construct(
      */
     public function _resetState(): void
     {
-        parent::_resetState();
         $this->queryText = null;
         $this->search = null;
         $this->searchCriteriaBuilder = null;
         $this->searchResult = null;
         $this->filterBuilder = null;
         $this->searchOrders = null;
+        parent::_resetState();
     }
 
     /**

app/code/Magento/Cms/Model/ResourceModel/Block/Grid/Collection.php

@@ -34,6 +34,12 @@ class Collection extends BlockCollection implements SearchResultInterface
      */
     protected $aggregations;
 
+    /** @var string */
+    private $model;
+
+    /** @var string */
+    private $resourceModel;
+
     /**
      * @param EntityFactoryInterface $entityFactory
      * @param LoggerInterface $logger
@@ -68,6 +74,8 @@ public function __construct(
         AbstractDb $resource = null,
         TimezoneInterface $timeZone = null
     ) {
+        $this->resourceModel = $resourceModel;
+        $this->model = $model;
         parent::__construct(
             $entityFactory,
             $logger,
@@ -80,11 +88,20 @@ public function __construct(
         );
         $this->_eventPrefix = $eventPrefix;
         $this->_eventObject = $eventObject;
-        $this->_init($model, $resourceModel);
+        $this->_init($this->model, $this->resourceModel);
         $this->setMainTable($mainTable);
         $this->timeZone = $timeZone ?: ObjectManager::getInstance()->get(TimezoneInterface::class);
     }
 
+    /**
+     * @inheritDoc
+     */
+    public function _resetState(): void
+    {
+        parent::_resetState();
+        $this->_init($this->model, $this->resourceModel);
+    }
+
     /**
      * @inheritDoc
      */

app/code/Magento/Cms/Model/ResourceModel/Page/Grid/Collection.php

@@ -34,6 +34,12 @@ class Collection extends PageCollection implements SearchResultInterface
      */
     protected $aggregations;
 
+    /** @var mixed */
+    private $model;
+
+    /** @var string */
+    private $resourceModel;
+
     /**
      * @param EntityFactoryInterface $entityFactory
      * @param LoggerInterface $logger
@@ -68,6 +74,8 @@ public function __construct(
         AbstractDb $resource = null,
         TimezoneInterface $timeZone = null
     ) {
+        $this->resourceModel = $resourceModel;
+        $this->model = $model;
         parent::__construct(
             $entityFactory,
             $logger,
@@ -80,11 +88,20 @@ public function __construct(
         );
         $this->_eventPrefix = $eventPrefix;
         $this->_eventObject = $eventObject;
-        $this->_init($model, $resourceModel);
+        $this->_init($this->model, $this->resourceModel);
         $this->setMainTable($mainTable);
         $this->timeZone = $timeZone ?: ObjectManager::getInstance()->get(TimezoneInterface::class);
     }
 
+    /**
+     * @inheritDoc
+     */
+    public function _resetState(): void
+    {
+        parent::_resetState();
+        $this->_init($this->model, $this->resourceModel);
+    }
+
     /**
      * @inheritDoc
      */

app/code/Magento/ConfigurableProduct/Model/Product/VariationHandler.php

@@ -45,7 +45,7 @@ class VariationHandler implements ResetAfterRequestInterface
     protected $productFactory;
 
     /**
-     * @var \Magento\Eav\Model\Entity\Attribute\AbstractAttribute[]
+     * @var \Magento\Eav\Model\Entity\Attribute\AbstractAttribute[]|null
      */
     private $attributes;
 
@@ -309,6 +309,6 @@ function ($image) {
      */
     public function _resetState(): void
     {
-        $this->attributes = [];
+        $this->attributes = null;
     }
 }

app/code/Magento/ConfigurableProduct/Pricing/Price/ConfigurableOptionsProvider.php

@@ -22,7 +22,7 @@ class ConfigurableOptionsProvider implements ConfigurableOptionsProviderInterfac
     private $configurable;
 
     /**
-     * @var ProductInterface[]
+     * @var ProductInterface[]|null
      */
     private $products;
 
@@ -63,6 +63,6 @@ public function getProducts(ProductInterface $product)
      */
     public function _resetState(): void
     {
-        $this->products = [];
+        $this->products = null;
     }
 }

app/code/Magento/Customer/Helper/Address.php

@@ -429,7 +429,7 @@ public function isAttributeVisible($code)
     public function _resetState(): void
     {
         $this->_config = [];
-        $this->_attributes = [];
+        $this->_attributes = null;
         $this->_streetLines = [];
     }
 }