ENGCOM-8551: #31168 fix for customer which have more than two subscriptions #31261

 - Merge Pull Request #31261 from korovitskyi/magento2:31168_fix_exception_on_customer_getlist
 - Merged commits:
   1. f5cc98e
   2. 66c3bff
   3. b19a6dc

Author: magento-engcom-team

app/code/Magento/Newsletter/Model/Plugin/CustomerPlugin.php

@@ -244,11 +244,21 @@ public function afterGetById(CustomerRepositoryInterface $subject, CustomerInter
      */
     public function afterGetList(CustomerRepositoryInterface $subject, SearchResults $searchResults): SearchResults
     {
+        $customerEmails = [];
+
+        foreach ($searchResults->getItems() as $customer) {
+            $customerEmails[] = $customer->getEmail();
+        }
+
+        $collection = $this->collectionFactory->create();
+        $collection->addFieldToFilter('subscriber_email', ['in' => $customerEmails]);
+
         foreach ($searchResults->getItems() as $customer) {
             /** @var CustomerExtensionInterface $extensionAttributes */
             $extensionAttributes = $customer->getExtensionAttributes();
-
-            $isSubscribed = (int) $extensionAttributes->getIsSubscribed() === Subscriber::STATUS_SUBSCRIBED ?: false;
+            /** @var Subscriber $subscribe */
+            $subscribe = $collection->getItemByColumnValue('subscriber_email', $customer->getEmail());
+            $isSubscribed = $subscribe && (int) $subscribe->getStatus() === Subscriber::STATUS_SUBSCRIBED;
             $extensionAttributes->setIsSubscribed($isSubscribed);
         }
 

app/code/Magento/Newsletter/etc/extension_attributes.xml

@@ -8,10 +8,6 @@
 
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Api/etc/extension_attributes.xsd">
     <extension_attributes for="Magento\Customer\Api\Data\CustomerInterface">
-        <attribute code="is_subscribed" type="boolean" >
-            <join reference_table="newsletter_subscriber" reference_field="customer_id" join_on_field="entity_id">
-                <field>subscriber_status</field>
-            </join>
-        </attribute>
+        <attribute code="is_subscribed" type="boolean"/>
     </extension_attributes>
 </config>

dev/tests/integration/testsuite/Magento/Newsletter/Model/Plugin/PluginTest.php

@@ -205,4 +205,22 @@ public function testCustomerWithZeroStoreIdIsSubscribed()
         $this->assertEquals($customer->getId(), (int)$subscriber->getCustomerId());
         $this->assertEquals($currentStore, (int)$subscriber->getStoreId());
     }
+
+    /**
+     * Test get list customer, which have more then 2 subscribes in newsletter_subscriber.
+     *
+     * @magentoAppArea frontend
+     * @magentoDataFixture Magento/Newsletter/_files/subscribers.php
+     */
+    public function testCustomerWithTwoNewsLetterSubscriptions()
+    {
+        /** @var \Magento\Framework\Api\SearchCriteriaBuilder $searchBuilder */
+        $searchBuilder = Bootstrap::getObjectManager()->create(\Magento\Framework\Api\SearchCriteriaBuilder::class);
+        $searchCriteria = $searchBuilder->addFilter('entity_id', 1)->create();
+        $items = $this->customerRepository->getList($searchCriteria)->getItems();
+        /** @var \Magento\Customer\Api\Data\CustomerInterface $customer */
+        $customer = $items[0];
+        $extensionAttributes = $customer->getExtensionAttributes();
+        $this->assertTrue($extensionAttributes->getIsSubscribed());
+    }
 }