Skip to content

Commit 27149cb

Browse files
committed
MAGETWO-80197: [2.2.x] - Fix JS translation search #10445
1 parent 7ca7002 commit 27149cb

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

app/code/Magento/Translation/Model/Js/DataProvider.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,12 +134,13 @@ protected function getPhrases($content)
134134
{
135135
$phrases = [];
136136
foreach ($this->config->getPatterns() as $pattern) {
137-
$result = preg_match_all($pattern, $content, $matches);
137+
$concatenatedContent = preg_replace('~(["\'])\s*?\+\s*?\1~', '', $content);
138+
$result = preg_match_all($pattern, $concatenatedContent, $matches);
138139

139140
if ($result) {
140141
if (isset($matches[2])) {
141142
foreach ($matches[2] as $match) {
142-
$phrases[] = str_replace('\\\'', '\'', $match);
143+
$phrases[] = str_replace(["\'", '\"'], ["'", '"'], $match);
143144
}
144145
}
145146
}

app/code/Magento/Translation/etc/di.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@
6565
<argument name="patterns" xsi:type="array">
6666
<item name="i18n_translation" xsi:type="string"><![CDATA[~i18n\:\s*(["'])(.*?)(?<!\\)\1~]]></item>
6767
<item name="translate_wrapping" xsi:type="string"><![CDATA[~translate\=("')([^\'].*?)\'\"~]]></item>
68-
<item name="mage_translation_widget" xsi:type="string">~\$\.mage\.__\((?s)[^'"]*?(['"])(.+?)\1(?s).*?\)~</item>
69-
<item name="mage_translation_static" xsi:type="string">~\$t\((?s)[^'"]*?(["'])(.+?)\1(?s).*?\)~</item>
68+
<item name="mage_translation_widget" xsi:type="string"><![CDATA[~(?:\$|jQuery)\.mage\.__\((?s)[^'"]*?(['"])(.+?)(?<!\\)\1(?s).*?\)~]]></item>
69+
<item name="mage_translation_static" xsi:type="string"><![CDATA[~\$t\((?s)[^'"]*?(["'])(.+?)\1(?s).*?\)~]]></item>
7070
</argument>
7171
</arguments>
7272
</type>

0 commit comments

Comments
 (0)