Test case for getting totals with no quote address set

Author: rogyar

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/CartTotalsTest.php

@@ -73,7 +73,6 @@ public function testGetCartTotalsWithTaxApplied()
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php
-     * @group last
      */
     public function testGetTotalsWithNoTaxApplied()
     {
@@ -89,6 +88,26 @@ public function testGetTotalsWithNoTaxApplied()
         self::assertEmpty($pricesResponse['applied_taxes']);
     }
 
+    /**
+     * The totals calculation is based on quote address.
+     * But the totals should be calculated even if no address is set
+     *
+     * @magentoApiDataFixture Magento/Checkout/_files/quote_with_customer_no_address.php
+     */
+    public function testGetCartTotalsWithNoAddressSet()
+    {
+        $maskedQuoteId = $this->getMaskedQuoteIdByReversedQuoteId('test_order_1');
+        $query = $this->getCartTotalsGraphqlQuery($maskedQuoteId);
+        $response = $this->sendRequestWithToken($query);
+
+        $pricesResponse = $response['cart']['prices'];
+        self::assertEquals(10, $pricesResponse['grand_total']['value']);
+        self::assertEquals(10, $pricesResponse['subtotal_including_tax']['value']);
+        self::assertEquals(10, $pricesResponse['subtotal_excluding_tax']['value']);
+        self::assertEquals(10, $pricesResponse['subtotal_with_discount_excluding_tax']['value']);
+        self::assertEmpty($pricesResponse['applied_taxes']);
+    }
+
     /**
      * Generates GraphQl query for retrieving cart totals
      *

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/CartTotalsTest.php

@@ -81,6 +81,26 @@ public function testGetTotalsWithNoTaxApplied()
         self::assertEmpty($pricesResponse['applied_taxes']);
     }
 
+    /**
+     * The totals calculation is based on quote address.
+     * But the totals should be calculated even if no address is set
+     *
+     * @magentoApiDataFixture Magento/Checkout/_files/quote_with_simple_product_saved.php
+     */
+    public function testGetCartTotalsWithNoAddressSet()
+    {
+        $maskedQuoteId = $this->getMaskedQuoteIdByReversedQuoteId('test_order_with_simple_product_without_address');
+        $query = $this->getCartTotalsGraphqlQuery($maskedQuoteId);
+        $response = $this->graphQlQuery($query);
+
+        $pricesResponse = $response['cart']['prices'];
+        self::assertEquals(10, $pricesResponse['grand_total']['value']);
+        self::assertEquals(10, $pricesResponse['subtotal_including_tax']['value']);
+        self::assertEquals(10, $pricesResponse['subtotal_excluding_tax']['value']);
+        self::assertEquals(10, $pricesResponse['subtotal_with_discount_excluding_tax']['value']);
+        self::assertEmpty($pricesResponse['applied_taxes']);
+    }
+
     /**
      * Generates GraphQl query for retrieving cart totals
      *

dev/tests/integration/testsuite/Magento/Checkout/_files/quote_with_customer_no_address_rollback.php

@@ -0,0 +1,22 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+use Magento\Quote\Model\Quote;
+use Magento\Quote\Model\QuoteIdMask;
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\TestFramework\ObjectManager;
+
+require __DIR__ . '/../../Customer/_files/customer_rollback.php';
+require __DIR__ . '/../../../Magento/Catalog/_files/products_rollback.php';
+
+/** @var $objectManager ObjectManager */
+$objectManager = Bootstrap::getObjectManager();
+$quote = $objectManager->create(Quote::class);
+$quote->load('test_order_1', 'reserved_order_id')->delete();
+
+/** @var QuoteIdMask $quoteIdMask */
+$quoteIdMask = $objectManager->create(QuoteIdMask::class);
+$quoteIdMask->delete($quote->getId());

dev/tests/integration/testsuite/Magento/Checkout/_files/quote_with_tax_customer.php

@@ -59,8 +59,8 @@
 $quoteRepository->save($quote);
 
 /** @var \Magento\Quote\Model\QuoteIdMask $quoteIdMask */
-$quoteIdMask = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
-    ->create(\Magento\Quote\Model\QuoteIdMaskFactory::class)
+$quoteIdMask = $objectManager
+    ->get(\Magento\Quote\Model\QuoteIdMaskFactory::class)
     ->create();
 $quoteIdMask->setQuoteId($quote->getId());
 $quoteIdMask->setDataChanges(true);

dev/tests/integration/testsuite/Magento/Checkout/_files/quote_with_tax_guest.php

@@ -39,7 +39,7 @@
 )->setBillingAddress(
     $quoteAddress
 )->setCheckoutMethod(
-    'customer'
+    'guest'
 )->setReservedOrderId(
     'test_order_tax'
 )->addProduct(
@@ -55,8 +55,8 @@
 $quoteRepository->save($quote);
 
 /** @var \Magento\Quote\Model\QuoteIdMask $quoteIdMask */
-$quoteIdMask = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
-    ->create(\Magento\Quote\Model\QuoteIdMaskFactory::class)
+$quoteIdMask = $objectManager
+    ->get(\Magento\Quote\Model\QuoteIdMaskFactory::class)
     ->create();
 $quoteIdMask->setQuoteId($quote->getId());
 $quoteIdMask->setDataChanges(true);