Skip to content

Commit 352bd0c

Browse files
Oleksii Korshenkoarkadiych
Oleksii Korshenko
authored andcommitted
MAGETWO-46678: Process public PRs and Issues
- fixed public GitHub issue #2630
1 parent dc4a971 commit 352bd0c

File tree

2 files changed

+15
-1
lines changed
  • app/code/Magento/Checkout/view/frontend/web/template/form/element
  • setup/src/Magento/Setup/Module/I18n/Parser/Adapter

2 files changed

+15
-1
lines changed

app/code/Magento/Checkout/view/frontend/web/template/form/element/email.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
data-validate="{required:true, 'validate-email':true}"
2828
id="customer-email" />
2929
<!-- ko template: 'ui/form/element/helper/tooltip' --><!-- /ko -->
30-
<span class="note" data-bind="fadeVisible: isPasswordVisible() == false"><!-- ko i18n: "You can create an account after checkout."--><!-- /ko --></span>
30+
<span class="note" data-bind="fadeVisible: isPasswordVisible() == false"><!-- ko i18n: 'You can create an account after checkout.'--><!-- /ko --></span>
3131
</div>
3232
</div>
3333

setup/src/Magento/Setup/Module/I18n/Parser/Adapter/Html.php

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,13 @@
1212
*/
1313
class Html extends AbstractAdapter
1414
{
15+
/**
16+
* Covers
17+
* <span><!-- ko i18n: 'Next'--><!-- /ko --></span>
18+
* <th class="col col-method" data-bind="i18n: 'Select Method'"></th>
19+
*/
20+
const HTML_FILTER = "/i18n:\s?'(?<value>.*)'/i";
21+
1522
/**
1623
* {@inheritdoc}
1724
*/
@@ -34,5 +41,12 @@ protected function _parse()
3441
$this->_addPhrase($quote . $directive[2] . $quote);
3542
}
3643
}
44+
45+
preg_match_all(self::HTML_FILTER, $data, $results, PREG_SET_ORDER);
46+
for ($i = 0; $i < count($results); $i++) {
47+
if (!empty($results[$i]['value'])) {
48+
$this->_addPhrase($results[$i]['value']);
49+
}
50+
}
3751
}
3852
}

0 commit comments

Comments
 (0)