Magento 8.1 fixes

Author: karyna-t

app/code/Magento/Backend/App/DefaultPath.php

@@ -24,7 +24,8 @@ class DefaultPath implements \Magento\Framework\App\DefaultPathInterface
      */
     public function __construct(\Magento\Backend\App\ConfigInterface $config)
     {
-        $pathParts = explode('/', $config->getValue('web/default/admin'));
+        $path = $config->getValue('web/default/admin');
+        $pathParts = $path ? explode('/', $path) : [''];
 
         $this->_parts = [
             'area' => isset($pathParts[0]) ? $pathParts[0] : '',

app/code/Magento/Backend/view/adminhtml/templates/widget/tabshoriz.phtml

@@ -19,7 +19,7 @@ use Magento\Framework\View\Helper\SecureHtmlRenderer;
     <?php foreach ($tabs as $_tab): ?>
         <?php $tabId = $block->getTabId($_tab) ?>
         <?php $_tabClass = 'tab-item-link ' . $block->getTabClass($_tab) . ' ' .
-            (preg_match('/\s?ajax\s?/', $_tab->getClass()) ? 'notloaded' : '') ?>
+            (preg_match('/\s?ajax\s?/', $_tab->getClass() ?? '') ? 'notloaded' : '') ?>
         <?php $_tabType = (!preg_match('/\s?ajax\s?/', $_tabClass) && $block->getTabUrl($_tab) != '#') ? 'link' : '' ?>
         <?php $_tabHref = $block->getTabUrl($_tab) == '#' ?
             '#' . $tabId . '_content' :

app/code/Magento/Eav/Model/Entity/Type.php

@@ -303,7 +303,7 @@ public function getValueTablePrefix()
      */
     public function getEntityTablePrefix()
     {
-        $tablePrefix = trim($this->_data['value_table_prefix']);
+        $tablePrefix = trim((string) $this->_data['value_table_prefix']);
 
         if (empty($tablePrefix)) {
             $tablePrefix = $this->getEntityTable();

app/code/Magento/Security/Observer/AdminUserAuthenticateBefore.php

@@ -56,7 +56,7 @@ public function execute(Observer $observer)
         /** @var \Magento\User\Model\User $user */
         $user->loadByUsername($username);
 
-        if ($user->getId() && $this->userExpirationManager->isUserExpired($user->getId())) {
+        if ($user->getId() && $this->userExpirationManager->isUserExpired((string) $user->getId())) {
             $this->userExpirationManager->deactivateExpiredUsersById([$user->getId()]);
             throw new AuthenticationException(
                 __(

app/code/Magento/Shipping/Model/Simplexml/Element.php

@@ -20,8 +20,7 @@ class Element extends \Magento\Framework\Simplexml\Element
      * @param string $namespace If specified, the namespace to which the attribute belongs.
      * @return void
      */
-    #[\ReturnTypeWillChange]
-    public function addAttribute($name, $value = null, $namespace = null)
+    public function addAttribute($name, $value = null, $namespace = null): void
     {
         $value = $value !== null ? $this->xmlentities($value) : '';
         parent::addAttribute($name, $value, $namespace);
@@ -35,8 +34,7 @@ public function addAttribute($name, $value = null, $namespace = null)
      * @param string $namespace If specified, the namespace to which the child element belongs.
      * @return \Magento\Shipping\Model\Simplexml\Element
      */
-    #[\ReturnTypeWillChange]
-    public function addChild($name, $value = null, $namespace = null)
+    public function addChild($name, $value = null, $namespace = null): self
     {
         if ($value !== null) {
             $value = $this->xmlentities($value);

lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php

@@ -1756,10 +1756,10 @@ public function getColumnCreateByDescribe($columnData)
         if ($columnData['DEFAULT'] !== null && $type != Table::TYPE_TEXT) {
             $options['default'] = $this->quote($columnData['DEFAULT']);
         }
-        if (strlen($columnData['SCALE']) > 0) {
+        if ($columnData['SCALE'] !== null && strlen($columnData['SCALE']) > 0) {
             $options['scale'] = $columnData['SCALE'];
         }
-        if (strlen($columnData['PRECISION']) > 0) {
+        if ($columnData['SCALE'] !== null && strlen($columnData['PRECISION']) > 0) {
             $options['precision'] = $columnData['PRECISION'];
         }
 

lib/internal/Magento/Framework/DB/Ddl/Table.php

@@ -381,7 +381,7 @@ public function addColumn($name, $type, $size = null, $options = [], $comment =
                         $precision = $size[0];
                         $scale = $size[1];
                     }
-                } elseif (preg_match('#^(\d+),(\d+)$#', $size, $match)) {
+                } elseif (preg_match('#^(\d+),(\d+)$#', $size ?? '', $match)) {
                     $precision = $match[1];
                     $scale = $match[2];
                 }

lib/internal/Magento/Framework/Stdlib/DateTime.php

@@ -70,7 +70,7 @@ public function formatDate($date, $includeTime = true)
      */
     public function isEmptyDate($date)
     {
-        return preg_replace('#[ 0:-]#', '', $date) === '';
+        return !$date || preg_replace('#[ 0:-]#', '', $date) === '';
     }
 
     /**

lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php

@@ -262,15 +262,15 @@ public function scopeTimeStamp($scope = null)
     /**
      * @inheritdoc
      */
-    public function isScopeDateInInterval($scope, $dateFrom = null, $dateTo = null)
+    public function isScopeDateInInterval($scope, $dateFrom = '', $dateTo = '')
     {
         if (!$scope instanceof ScopeInterface) {
             $scope = $this->_scopeResolver->getScope($scope);
         }
 
         $scopeTimeStamp = $this->scopeTimeStamp($scope);
-        $fromTimeStamp = strtotime($dateFrom);
-        $toTimeStamp = strtotime($dateTo);
+        $fromTimeStamp = strtotime((string) $dateFrom);
+        $toTimeStamp = strtotime((string) $dateTo);
         if ($dateTo) {
             // fix date YYYY-MM-DD 00:00:00 to YYYY-MM-DD 23:59:59
             $toTimeStamp += 86400;

lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php

@@ -122,7 +122,7 @@ public function getConfigTimezone($scopeType = null, $scopeCode = null);
      * @param string|null $dateTo
      * @return bool
      */
-    public function isScopeDateInInterval($scope, $dateFrom = null, $dateTo = null);
+    public function isScopeDateInInterval($scope, $dateFrom = '', $dateTo = '');
 
     /**
      * Format date according to date and time formats, locale, timezone and pattern.

lib/internal/Magento/Framework/Url.php

@@ -504,7 +504,7 @@ protected function _setRoutePath($data)
         }
 
         $this->unsetData('route_path');
-        $routePieces = explode('/', $data);
+        $routePieces = explode('/', $data ?? '');
 
         $route = array_shift($routePieces);
         if ('*' === $route) {