Skip to content

Commit 5d6c3fa

Browse files
authored
ENGCOM-5437: [2.2][Backport] Transfer Encoding of emails changed to QUOTED-PRINTABLE #23650
2 parents 5a17bf3 + c736a95 commit 5d6c3fa

File tree

14 files changed

+21
-14
lines changed

14 files changed

+21
-14
lines changed

dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -685,7 +685,7 @@ public function testConfirmationEmailWithSpecialCharacters()
685685

686686
$this->assertContains('To: ' . $email, $rawMessage);
687687

688-
$content = $message->getBody()->getPartContent(0);
688+
$content = $message->getBody()->getParts()[0]->getRawContent();
689689
$confirmationUrl = $this->getConfirmationUrlFromMessageContent($content);
690690
$this->setRequestInfo($confirmationUrl, 'confirm');
691691
$this->clearCookieMessagesList();

dev/tests/integration/testsuite/Magento/Newsletter/Model/SubscriberTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66

77
namespace Magento\Newsletter\Model;
88

9+
/**
10+
* \Magento\Newsletter\Model\Subscriber tests
11+
*/
912
class SubscriberTest extends \PHPUnit\Framework\TestCase
1013
{
1114
/**
@@ -39,7 +42,7 @@ public function testEmailConfirmation()
3942
$this->assertContains(
4043
'/newsletter/subscriber/confirm/id/' . $this->_model->getSubscriberId()
4144
. '/code/ysayquyajua23iq29gxwu2eax2qb6gvy',
42-
$transportBuilder->getSentMessage()->getRawMessage()
45+
$transportBuilder->getSentMessage()->getBody()->getParts()[0]->getRawContent()
4346
);
4447
$this->assertEquals(Subscriber::STATUS_NOT_ACTIVE, $this->_model->getSubscriberStatus());
4548
}

dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/Create/SaveTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ public function testSendEmailOnOrderSave()
141141
);
142142

143143
$this->assertEquals($message->getSubject(), $subject);
144-
$this->assertThat($message->getRawMessage(), $assert);
144+
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $assert);
145145
}
146146

147147
/**

dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/AddCommentTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public function testSendEmailOnAddCreditmemoComment()
5454
);
5555

5656
$this->assertEquals($message->getSubject(), $subject);
57-
$this->assertThat($message->getRawMessage(), $messageConstraint);
57+
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
5858
}
5959

6060
/**

dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/SaveTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function testSendEmailOnCreditmemoSave()
5151
);
5252

5353
$this->assertEquals($message->getSubject(), $subject);
54-
$this->assertThat($message->getRawMessage(), $messageConstraint);
54+
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
5555
}
5656

5757
/**

dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/EmailTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public function testSendOrderEmail()
8282
);
8383

8484
$this->assertEquals($message->getSubject(), $subject);
85-
$this->assertThat($message->getRawMessage(), $assert);
85+
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $assert);
8686
}
8787

8888
/**

dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/AddCommentTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public function testSendEmailOnAddInvoiceComment()
5555
);
5656

5757
$this->assertEquals($message->getSubject(), $subject);
58-
$this->assertThat($message->getRawMessage(), $messageConstraint);
58+
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
5959
}
6060

6161
/**

dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/EmailTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public function testSendInvoiceEmail()
5959
);
6060

6161
$this->assertEquals($message->getSubject(), $subject);
62-
$this->assertThat($message->getRawMessage(), $messageConstraint);
62+
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
6363
}
6464

6565
/**

dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/SaveTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function testSendEmailOnInvoiceSave()
5151
);
5252

5353
$this->assertEquals($message->getSubject(), $subject);
54-
$this->assertThat($message->getRawMessage(), $messageConstraint);
54+
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
5555
}
5656

5757
/**

dev/tests/integration/testsuite/Magento/Sales/Model/Order/CreateTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,6 @@ public function testSendEmailOnOrderPlace()
9595
);
9696

9797
$this->assertEquals($message->getSubject(), $subject);
98-
$this->assertThat($message->getRawMessage(), $assert);
98+
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $assert);
9999
}
100100
}

dev/tests/integration/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/AddCommentTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public function testSendEmailOnShipmentCommentAdd()
5454
);
5555

5656
$this->assertEquals($message->getSubject(), $subject);
57-
$this->assertThat($message->getRawMessage(), $messageConstraint);
57+
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
5858
}
5959

6060
/**

dev/tests/integration/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/SaveTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function testSendEmailOnShipmentSave()
5151
);
5252

5353
$this->assertEquals($message->getSubject(), $subject);
54-
$this->assertThat($message->getRawMessage(), $messageConstraint);
54+
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
5555
}
5656

5757
/**

lib/internal/Magento/Framework/Mail/Message.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,8 @@ private function createMimeFromString($body, $messageType)
182182
{
183183
$part = new Part($body);
184184
$part->setCharset($this->zendMessage->getEncoding());
185+
$part->setEncoding(Mime::ENCODING_QUOTEDPRINTABLE);
186+
$part->setDisposition(Mime::DISPOSITION_INLINE);
185187
$part->setType($messageType);
186188
$mimeMessage = new \Zend\Mime\Message();
187189
$mimeMessage->addPart($part);

lib/internal/Magento/Framework/Mail/Test/Unit/MessageTest.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,10 @@ public function testSetBodyHtml()
2626

2727
$part = $this->message->getBody()->getParts()[0];
2828
$this->assertEquals('text/html', $part->getType());
29-
$this->assertEquals('8bit', $part->getEncoding());
29+
$this->assertEquals('quoted-printable', $part->getEncoding());
3030
$this->assertEquals('utf-8', $part->getCharset());
3131
$this->assertEquals('body', $part->getContent());
32+
$this->assertEquals('inline', $part->getDisposition());
3233
}
3334

3435
public function testSetBodyText()
@@ -37,8 +38,9 @@ public function testSetBodyText()
3738

3839
$part = $this->message->getBody()->getParts()[0];
3940
$this->assertEquals('text/plain', $part->getType());
40-
$this->assertEquals('8bit', $part->getEncoding());
41+
$this->assertEquals('quoted-printable', $part->getEncoding());
4142
$this->assertEquals('utf-8', $part->getCharset());
4243
$this->assertEquals('body', $part->getContent());
44+
$this->assertEquals('inline', $part->getDisposition());
4345
}
4446
}

0 commit comments

Comments
 (0)