MAGETWO-32870: [GITHUB] extra tests for current interception behavior #965

otoolec · otoolec · commit 5ed5b2248874 · 2015-01-26T09:09:56.000-06:00
- Suppress warnings for test fixtures
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted.php b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted.php
@@ -78,26 +78,41 @@ public function K($param1)
         return '<K>' . $param1 . '</K>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.ShortMethodName)
+     */
     public function V($param1)
     {
         return '<V>' . $param1 . '</V>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.ShortMethodName)
+     */
     public function W($param1)
     {
         return '<W>' . $param1 . '</W>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.ShortMethodName)
+     */
     public function X($param1)
     {
         return '<X>' . $param1 . '</X>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.ShortMethodName)
+     */
     public function Y($param1)
     {
         return '<Y>' . $param1 . '</Y>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.ShortMethodName)
+     */
     public function Z($param1)
     {
         return '<Z>' . $param1 . '</Z>';
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/FirstPlugin.php b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/FirstPlugin.php
@@ -14,73 +14,115 @@ class FirstPlugin
      */
     protected $_counter = 0;
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function aroundC(Intercepted $subject, \Closure $next, $param1)
     {
         return '<F:C>' . $next($param1) . '</F:C>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function aroundD(Intercepted $subject, \Closure $next, $param1)
     {
         $this->_counter++;
         return '<F:D>' . $this->_counter . ': ' . $next($param1) . '</F:D>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function aroundK(Intercepted $subject, \Closure $next, $param1)
     {
         $result = $subject->C($param1);
         return '<F:K>' . $subject->F($result) . '</F:K>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function beforeG(Intercepted $subject, $param1)
     {
         return ['<F:bG>' . $param1 . '</F:bG>'];
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function aroundG(Intercepted $subject, \Closure $next, $param1)
     {
         return $next('<F:G>' . $param1 . '</F:G>');
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function afterG(Intercepted $subject, $result)
     {
         return '<F:aG>' . $result . '</F:aG>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function beforeV(Intercepted $subject, $param1)
     {
         return ['<F:bV/>'];
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function aroundV(Intercepted $subject, \Closure $next, $param1)
     {
         return '<F:V>' . $param1 . '<F:V/>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function beforeW(Intercepted $subject, $param1)
     {
         return ['<F:bW/>'];
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function aroundW(Intercepted $subject, \Closure $next, $param1)
     {
         return '<F:W>' . $param1 . '<F:W/>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function afterW(Intercepted $subject, $result)
     {
         return '<F:aW/>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function beforeX(Intercepted $subject, $param1)
     {
         return ['<F:bX/>'];
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function aroundY(Intercepted $subject, \Closure $next, $param1)
     {
         return '<F:Y>' . $param1 . '<F:Y/>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function afterZ(Intercepted $subject, $result)
     {
         return '<F:aZ/>';
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/Plugin.php b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/Plugin.php
@@ -65,41 +65,65 @@ public function afterG(Intercepted $subject, $result)
         return '<P:aG>' . $result . '</P:aG>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function beforeV(Intercepted $subject, $param1)
     {
         return ['<P:bV/>'];
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function aroundV(Intercepted $subject, \Closure $next, $param1)
     {
         return '<P:V>' . $param1 . '<P:V/>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function beforeW(Intercepted $subject, $param1)
     {
         return ['<P:bW/>'];
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function aroundW(Intercepted $subject, \Closure $next, $param1)
     {
         return '<P:W>' . $param1 . '<P:W/>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function afterW(Intercepted $subject, $result)
     {
         return '<P:aW/>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function beforeX(Intercepted $subject, $param1)
     {
         return ['<P:bX/>'];
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function aroundY(Intercepted $subject, \Closure $next, $param1)
     {
         return '<P:Y>' . $param1 . '<P:Y/>';
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function afterZ(Intercepted $subject, $result)
     {
         return '<P:aZ/>';

Original file line number	Diff line number	Diff line change
`@@ -78,26 +78,41 @@ public function K($param1)`
`78`	`78`	`return '<K>' . $param1 . '</K>';`
`79`	`79`	`}`
`80`	`80`
	`81`	`+ /**`
	`82`	`+ * @SuppressWarnings(PHPMD.ShortMethodName)`
	`83`	`+ */`
`81`	`84`	`public function V($param1)`
`82`	`85`	`{`
`83`	`86`	`return '<V>' . $param1 . '</V>';`
`84`	`87`	`}`
`85`	`88`
	`89`	`+ /**`
	`90`	`+ * @SuppressWarnings(PHPMD.ShortMethodName)`
	`91`	`+ */`
`86`	`92`	`public function W($param1)`
`87`	`93`	`{`
`88`	`94`	`return '<W>' . $param1 . '</W>';`
`89`	`95`	`}`
`90`	`96`
	`97`	`+ /**`
	`98`	`+ * @SuppressWarnings(PHPMD.ShortMethodName)`
	`99`	`+ */`
`91`	`100`	`public function X($param1)`
`92`	`101`	`{`
`93`	`102`	`return '<X>' . $param1 . '</X>';`
`94`	`103`	`}`
`95`	`104`
	`105`	`+ /**`
	`106`	`+ * @SuppressWarnings(PHPMD.ShortMethodName)`
	`107`	`+ */`
`96`	`108`	`public function Y($param1)`
`97`	`109`	`{`
`98`	`110`	`return '<Y>' . $param1 . '</Y>';`
`99`	`111`	`}`
`100`	`112`
	`113`	`+ /**`
	`114`	`+ * @SuppressWarnings(PHPMD.ShortMethodName)`
	`115`	`+ */`
`101`	`116`	`public function Z($param1)`
`102`	`117`	`{`
`103`	`118`	`return '<Z>' . $param1 . '</Z>';`
Original file line number	Diff line number	Diff line change
`@@ -14,73 +14,115 @@ class FirstPlugin`
`14`	`14`	`*/`
`15`	`15`	`protected $_counter = 0;`
`16`	`16`
	`17`	`+ /**`
	`18`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`19`	`+ */`
`17`	`20`	`public function aroundC(Intercepted $subject, \Closure $next, $param1)`
`18`	`21`	`{`
`19`	`22`	`return '<F:C>' . $next($param1) . '</F:C>';`
`20`	`23`	`}`
`21`	`24`
	`25`	`+ /**`
	`26`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`27`	`+ */`
`22`	`28`	`public function aroundD(Intercepted $subject, \Closure $next, $param1)`
`23`	`29`	`{`
`24`	`30`	`$this->_counter++;`
`25`	`31`	`return '<F:D>' . $this->_counter . ': ' . $next($param1) . '</F:D>';`
`26`	`32`	`}`
`27`	`33`
	`34`	`+ /**`
	`35`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`36`	`+ */`
`28`	`37`	`public function aroundK(Intercepted $subject, \Closure $next, $param1)`
`29`	`38`	`{`
`30`	`39`	`$result = $subject->C($param1);`
`31`	`40`	`return '<F:K>' . $subject->F($result) . '</F:K>';`
`32`	`41`	`}`
`33`	`42`
	`43`	`+ /**`
	`44`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`45`	`+ */`
`34`	`46`	`public function beforeG(Intercepted $subject, $param1)`
`35`	`47`	`{`
`36`	`48`	`return ['<F:bG>' . $param1 . '</F:bG>'];`
`37`	`49`	`}`
`38`	`50`
	`51`	`+ /**`
	`52`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`53`	`+ */`
`39`	`54`	`public function aroundG(Intercepted $subject, \Closure $next, $param1)`
`40`	`55`	`{`
`41`	`56`	`return $next('<F:G>' . $param1 . '</F:G>');`
`42`	`57`	`}`
`43`	`58`
	`59`	`+ /**`
	`60`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`61`	`+ */`
`44`	`62`	`public function afterG(Intercepted $subject, $result)`
`45`	`63`	`{`
`46`	`64`	`return '<F:aG>' . $result . '</F:aG>';`
`47`	`65`	`}`
`48`	`66`
	`67`	`+ /**`
	`68`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`69`	`+ */`
`49`	`70`	`public function beforeV(Intercepted $subject, $param1)`
`50`	`71`	`{`
`51`	`72`	`return ['<F:bV/>'];`
`52`	`73`	`}`
`53`	`74`
	`75`	`+ /**`
	`76`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`77`	`+ */`
`54`	`78`	`public function aroundV(Intercepted $subject, \Closure $next, $param1)`
`55`	`79`	`{`
`56`	`80`	`return '<F:V>' . $param1 . '<F:V/>';`
`57`	`81`	`}`
`58`	`82`
	`83`	`+ /**`
	`84`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`85`	`+ */`
`59`	`86`	`public function beforeW(Intercepted $subject, $param1)`
`60`	`87`	`{`
`61`	`88`	`return ['<F:bW/>'];`
`62`	`89`	`}`
`63`	`90`
	`91`	`+ /**`
	`92`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`93`	`+ */`
`64`	`94`	`public function aroundW(Intercepted $subject, \Closure $next, $param1)`
`65`	`95`	`{`
`66`	`96`	`return '<F:W>' . $param1 . '<F:W/>';`
`67`	`97`	`}`
`68`	`98`
	`99`	`+ /**`
	`100`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`101`	`+ */`
`69`	`102`	`public function afterW(Intercepted $subject, $result)`
`70`	`103`	`{`
`71`	`104`	`return '<F:aW/>';`
`72`	`105`	`}`
`73`	`106`
	`107`	`+ /**`
	`108`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`109`	`+ */`
`74`	`110`	`public function beforeX(Intercepted $subject, $param1)`
`75`	`111`	`{`
`76`	`112`	`return ['<F:bX/>'];`
`77`	`113`	`}`
`78`	`114`
	`115`	`+ /**`
	`116`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`117`	`+ */`
`79`	`118`	`public function aroundY(Intercepted $subject, \Closure $next, $param1)`
`80`	`119`	`{`
`81`	`120`	`return '<F:Y>' . $param1 . '<F:Y/>';`
`82`	`121`	`}`
`83`	`122`
	`123`	`+ /**`
	`124`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`125`	`+ */`
`84`	`126`	`public function afterZ(Intercepted $subject, $result)`
`85`	`127`	`{`
`86`	`128`	`return '<F:aZ/>';`
Original file line number	Diff line number	Diff line change
`@@ -65,41 +65,65 @@ public function afterG(Intercepted $subject, $result)`
`65`	`65`	`return '<P:aG>' . $result . '</P:aG>';`
`66`	`66`	`}`
`67`	`67`
	`68`	`+ /**`
	`69`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`70`	`+ */`
`68`	`71`	`public function beforeV(Intercepted $subject, $param1)`
`69`	`72`	`{`
`70`	`73`	`return ['<P:bV/>'];`
`71`	`74`	`}`
`72`	`75`
	`76`	`+ /**`
	`77`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`78`	`+ */`
`73`	`79`	`public function aroundV(Intercepted $subject, \Closure $next, $param1)`
`74`	`80`	`{`
`75`	`81`	`return '<P:V>' . $param1 . '<P:V/>';`
`76`	`82`	`}`
`77`	`83`
	`84`	`+ /**`
	`85`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`86`	`+ */`
`78`	`87`	`public function beforeW(Intercepted $subject, $param1)`
`79`	`88`	`{`
`80`	`89`	`return ['<P:bW/>'];`
`81`	`90`	`}`
`82`	`91`
	`92`	`+ /**`
	`93`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`94`	`+ */`
`83`	`95`	`public function aroundW(Intercepted $subject, \Closure $next, $param1)`
`84`	`96`	`{`
`85`	`97`	`return '<P:W>' . $param1 . '<P:W/>';`
`86`	`98`	`}`
`87`	`99`
	`100`	`+ /**`
	`101`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`102`	`+ */`
`88`	`103`	`public function afterW(Intercepted $subject, $result)`
`89`	`104`	`{`
`90`	`105`	`return '<P:aW/>';`
`91`	`106`	`}`
`92`	`107`
	`108`	`+ /**`
	`109`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`110`	`+ */`
`93`	`111`	`public function beforeX(Intercepted $subject, $param1)`
`94`	`112`	`{`
`95`	`113`	`return ['<P:bX/>'];`
`96`	`114`	`}`
`97`	`115`
	`116`	`+ /**`
	`117`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`118`	`+ */`
`98`	`119`	`public function aroundY(Intercepted $subject, \Closure $next, $param1)`
`99`	`120`	`{`
`100`	`121`	`return '<P:Y>' . $param1 . '<P:Y/>';`
`101`	`122`	`}`
`102`	`123`
	`124`	`+ /**`
	`125`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`126`	`+ */`
`103`	`127`	`public function afterZ(Intercepted $subject, $result)`
`104`	`128`	`{`
`105`	`129`	`return '<P:aZ/>';`