Skip to content

Commit 5ee9da5

Browse files
committed
Merge pull request #69 from AnastasiaBuniakEPAM/JS-357
JS-357: Fix theme variable's names
2 parents 4f8c1a6 + cba7214 commit 5ee9da5

File tree

3 files changed

+14
-19
lines changed

3 files changed

+14
-19
lines changed

app/code/Magento/Catalog/view/frontend/templates/product/view/gallery.phtml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@
6868
"nav": "<?php /* @escapeNotVerified */ echo $block->getVar("gallery/fullscreen/nav"); ?>",
6969
"loop": <?php /* @escapeNotVerified */ echo $block->getVar("gallery/fullscreen/loop"); ?>,
7070
"navdir": "<?php /* @escapeNotVerified */ echo $block->getVar("gallery/fullscreen/navdir"); ?>",
71+
"navarrows": <?php /* @escapeNotVerified */ echo $block->getVar("gallery/fullscreen/navarrows"); ?>,
72+
"navtype": "<?php /* @escapeNotVerified */ echo $block->getVar("gallery/fullscreen/navtype"); ?>",
7173
"arrows": <?php /* @escapeNotVerified */ echo $block->getVar("gallery/fullscreen/arrows"); ?>,
7274
"showCaption": <?php /* @escapeNotVerified */ echo $block->getVar("gallery/fullscreen/caption"); ?>,
7375
"transitionduration": <?php /* @escapeNotVerified */ echo $block->getVar("gallery/fullscreen/transition/duration"); ?>,

app/design/frontend/Magento/blank/etc/view.xml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@
190190
<var name="caption">false</var> <!-- Display alt text as image title (true/false) -->
191191
<var name="allowfullscreen">true</var> <!-- Turn on/off fullscreen (true/false) -->
192192
<var name="navdir">horizontal</var> <!-- Sliding direction of thumbnails (horizontal/vertical) -->
193-
<var name="navarrows">true</var> <!-- Turn on/off on the thumbs navigation sides (true/false) -->
193+
<var name="navarrows">true</var> <!-- Turn on/off on the thumbs navigation sides arrows(true/false) -->
194194
<var name="navtype">slides</var> <!-- Sliding type of thumbnails (slides/thumbs) -->
195195
<var name="transition">
196196
<var name="effect">slide</var> <!-- Sets transition effect for slides changing (slide/crossfade/dissolve) -->
@@ -199,17 +199,13 @@
199199
<var name="fullscreen">
200200
<var name="nav">thumbs</var> <!-- Fullscreen navigation style (false/thumbs/dots) -->
201201
<var name="loop">true</var> <!-- Fullscreen navigation loop (true/false/null) -->
202-
<var name="keyboard">true</var> <!-- Turn on/off keyboard arrows navigation (true/false/null) -->
203-
<var name="arrows">false</var> <!-- Turn on/off arrows on the sides preview (true/false/null) -->
204-
<var name="caption">false</var> <!-- Display alt text as image title (true/false) -->
205-
<var name="navdir">horizontal</var> <!--Sliding direction of thumbnails in full screen(horizontal/vertical) -->
206-
<var name="thumbwidth">150</var> <!-- Width of thumbnails in fullscreen -->
207-
<var name="thumbheight">150</var> <!-- Height of thumbnails in fullscreen -->
208-
<var name="navigation_carousel">true</var> <!-- Display navigation thumbs as carousel (true/false) -->
202+
<var name="arrows">false</var> <!-- Turn on/off arrows on the sides preview in fullscreen (true/false/null) -->
203+
<var name="caption">false</var> <!-- Display alt text as image title in fullscreen(true/false) -->
204+
<var name="navdir">horizontal</var> <!--Sliding direction of thumbnails in fullscreen(horizontal/vertical) -->
205+
<var name="navtype">thumbs</var> <!-- Sliding type of thumbnails (slides/thumbs) -->
209206
<var name="transition">
210207
<var name="effect">dissolve</var> <!-- Sets transition effect for slides changing (slide/crossfade/dissolve) -->
211208
<var name="duration">500</var> <!-- Sets transition duration in ms -->
212-
<var name="carousel">true</var> <!-- Display navigation thumbs as carousel (true/false) -->
213209
</var>
214210
</var>
215211
</var>

app/design/frontend/Magento/luma/etc/view.xml

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@
194194
<var name="caption">false</var> <!-- Display alt text as image title (true/false) -->
195195
<var name="allowfullscreen">true</var> <!-- Turn on/off fullscreen (true/false) -->
196196
<var name="navdir">horizontal</var> <!-- Sliding direction of thumbnails (horizontal/vertical) -->
197-
<var name="navarrows">true</var> <!-- Turn on/off on the thumbs navigation sides (true/false) -->
197+
<var name="navarrows">true</var> <!-- Turn on/off on the thumbs navigation sides arrows(true/false) -->
198198
<var name="navtype">slides</var> <!-- Sliding type of thumbnails (slides/thumbs) -->
199199
<var name="transition">
200200
<var name="effect">slide</var> <!-- Sets transition effect for slides changing (slide/crossfade/dissolve) -->
@@ -203,17 +203,14 @@
203203
<var name="fullscreen">
204204
<var name="nav">thumbs</var> <!-- Fullscreen navigation style (false/thumbs/dots) -->
205205
<var name="loop">true</var> <!-- Fullscreen navigation loop (true/false/null) -->
206-
<var name="keyboard">true</var> <!-- Turn on/off keyboard arrows navigation (true/false/null) -->
207-
<var name="arrows">false</var> <!-- Turn on/off arrows on the sides preview (true/false/null) -->
208-
<var name="caption">false</var> <!-- Display alt text as image title (true/false) -->
209-
<var name="navdir">horizontal</var> <!--Sliding direction of thumbnails in full screen(horizontal/vertical) -->
210-
<var name="thumbwidth">150</var> <!-- Width of thumbnails in fullscreen -->
211-
<var name="thumbheight">150</var> <!-- Height of thumbnails in fullscreen -->
212-
<var name="navigation_carousel">true</var> <!-- Display navigation thumbs as carousel (true/false) -->
206+
<var name="arrows">false</var> <!-- Turn on/off arrows on the sides preview in fullscreen (true/false/null) -->
207+
<var name="caption">false</var> <!-- Display alt text as image title in fullscreen(true/false) -->
208+
<var name="navdir">horizontal</var> <!--Sliding direction of thumbnails in fullscreen(horizontal/vertical) -->
209+
<var name="navarrows">false</var> <!-- Turn on/off on the thumbs navigation sides arrows(true/false) -->
210+
<var name="navtype">thumbs</var> <!-- Sliding type of thumbnails (slides/thumbs) -->
213211
<var name="transition">
214212
<var name="effect">slide</var> <!-- Sets transition effect for slides changing (slide/crossfade/dissolve) -->
215213
<var name="duration">500</var> <!-- Sets transition duration in ms -->
216-
<var name="carousel">true</var> <!-- Display navigation thumbs as carousel (true/false) -->
217214
</var>
218215
</var>
219216
</var>
@@ -225,7 +222,7 @@
225222
<var name="width"></var> <!-- Width of magnifier block -->
226223
<var name="height"></var> <!-- Height of magnifier block -->
227224
<var name="eventType">hover</var> <!-- Action that atcivates zoom (hover/click) -->
228-
<var name="enabled">false</var> <!-- Turn on/off magnifier (true/false) -->
225+
<var name="enabled">true</var> <!-- Turn on/off magnifier (true/false) -->
229226
</var>
230227

231228
<var name="breakpoints">

0 commit comments

Comments
 (0)