Skip to content

Commit 7f24f76

Browse files
author
Stanislav Idolov
committed
magento-engcom/magento2ce#2280: Code style fixes
1 parent faa6814 commit 7f24f76

File tree

17 files changed

+79
-26
lines changed

17 files changed

+79
-26
lines changed

‎app/code/Magento/Catalog/Model/Api/SearchCriteria/CollectionProcessor/ConditionProcessor/ProductCategoryCondition.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ class ProductCategoryCondition implements CustomConditionInterface
3838

3939
/**
4040
* @param \Magento\Framework\App\ResourceConnection $resourceConnection
41+
* @param \Magento\Catalog\Model\CategoryRepository $categoryRepository
4142
*/
4243
public function __construct(
4344
\Magento\Framework\App\ResourceConnection $resourceConnection,

‎app/code/Magento/Catalog/Model/Product/Attribute/Repository.php

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
use Magento\Framework\Exception\NoSuchEntityException;
1212

1313
/**
14+
* Product attribute repository
15+
*
1416
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
1517
*/
1618
class Repository implements \Magento\Catalog\Api\ProductAttributeRepositoryInterface
@@ -78,7 +80,7 @@ public function __construct(
7880
}
7981

8082
/**
81-
* {@inheritdoc}
83+
* @inheritdoc
8284
*/
8385
public function get($attributeCode)
8486
{
@@ -89,7 +91,7 @@ public function get($attributeCode)
8991
}
9092

9193
/**
92-
* {@inheritdoc}
94+
* @inheritdoc
9395
*/
9496
public function getList(\Magento\Framework\Api\SearchCriteriaInterface $searchCriteria)
9597
{
@@ -100,7 +102,7 @@ public function getList(\Magento\Framework\Api\SearchCriteriaInterface $searchCr
100102
}
101103

102104
/**
103-
* {@inheritdoc}
105+
* @inheritdoc
104106
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
105107
* @SuppressWarnings(PHPMD.NPathComplexity)
106108
*/
@@ -180,7 +182,7 @@ public function save(\Magento\Catalog\Api\Data\ProductAttributeInterface $attrib
180182
}
181183

182184
/**
183-
* {@inheritdoc}
185+
* @inheritdoc
184186
*/
185187
public function delete(\Magento\Catalog\Api\Data\ProductAttributeInterface $attribute)
186188
{
@@ -189,7 +191,7 @@ public function delete(\Magento\Catalog\Api\Data\ProductAttributeInterface $attr
189191
}
190192

191193
/**
192-
* {@inheritdoc}
194+
* @inheritdoc
193195
*/
194196
public function deleteById($attributeCode)
195197
{
@@ -200,7 +202,7 @@ public function deleteById($attributeCode)
200202
}
201203

202204
/**
203-
* {@inheritdoc}
205+
* @inheritdoc
204206
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
205207
*/
206208
public function getCustomAttributesMetadata($dataObjectClassName = null)

‎app/code/Magento/Catalog/Model/ProductCategoryList.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ public function getCategoryIds($productId)
8484
'intval',
8585
$this->productResource->getConnection()->fetchCol($unionSelect)
8686
);
87-
8887
}
8988

9089
return $this->categoryIdList[$productId];

‎app/code/Magento/CatalogImportExport/Model/Import/Product/Validator.php

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ public function __construct(
6161
}
6262

6363
/**
64+
* Text validation
65+
*
6466
* @param mixed $attrCode
6567
* @param string $type
6668
* @return bool
@@ -108,6 +110,8 @@ private function validateOption($attrCode, $possibleOptions, $value)
108110
}
109111

110112
/**
113+
* Numeric validation
114+
*
111115
* @param mixed $attrCode
112116
* @param string $type
113117
* @return bool
@@ -135,6 +139,8 @@ protected function numericValidation($attrCode, $type)
135139
}
136140

137141
/**
142+
* Is required attribute valid
143+
*
138144
* @param string $attrCode
139145
* @param array $attributeParams
140146
* @param array $rowData
@@ -162,6 +168,8 @@ public function isRequiredAttributeValid($attrCode, array $attributeParams, arra
162168
}
163169

164170
/**
171+
* Is attribute valid
172+
*
165173
* @param string $attrCode
166174
* @param array $attrParams
167175
* @param array $rowData
@@ -258,6 +266,8 @@ public function isAttributeValid($attrCode, array $attrParams, array $rowData)
258266
}
259267

260268
/**
269+
* Set invalid attribute
270+
*
261271
* @param string|null $attribute
262272
* @return void
263273
* @since 100.1.0
@@ -268,6 +278,8 @@ protected function setInvalidAttribute($attribute)
268278
}
269279

270280
/**
281+
* Get invalid attribute
282+
*
271283
* @return string
272284
* @since 100.1.0
273285
*/
@@ -277,6 +289,8 @@ public function getInvalidAttribute()
277289
}
278290

279291
/**
292+
* Is valid attributes
293+
*
280294
* @return bool
281295
* @SuppressWarnings(PHPMD.UnusedLocalVariable)
282296
*/
@@ -303,7 +317,7 @@ protected function isValidAttributes()
303317
}
304318

305319
/**
306-
* {@inheritdoc}
320+
* @inheritdoc
307321
*/
308322
public function isValid($value)
309323
{
@@ -334,6 +348,8 @@ public function getRowScope(array $rowData)
334348
}
335349

336350
/**
351+
* Init
352+
*
337353
* @param \Magento\CatalogImportExport\Model\Import\Product $context
338354
* @return $this
339355
*/
@@ -344,4 +360,4 @@ public function init($context)
344360
$validator->init($context);
345361
}
346362
}
347-
}
363+
}

‎app/code/Magento/CatalogWidget/Block/Product/ProductsList.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,8 @@ private function getPriceCurrency()
410410
}
411411

412412
/**
413+
* Get widget block name
414+
*
413415
* @return string
414416
*/
415417
private function getWidgetPagerBlockName()

‎app/code/Magento/Checkout/Model/PaymentInformationManagement.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
use Magento\Framework\Exception\CouldNotSaveException;
1010

1111
/**
12+
* Payment information management
13+
*
1214
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
1315
*/
1416
class PaymentInformationManagement implements \Magento\Checkout\Api\PaymentInformationManagementInterface
@@ -72,7 +74,7 @@ public function __construct(
7274
}
7375

7476
/**
75-
* {@inheritDoc}
77+
* @inheritdoc
7678
*/
7779
public function savePaymentInformationAndPlaceOrder(
7880
$cartId,
@@ -98,7 +100,7 @@ public function savePaymentInformationAndPlaceOrder(
98100
}
99101

100102
/**
101-
* {@inheritDoc}
103+
* @inheritdoc
102104
*/
103105
public function savePaymentInformation(
104106
$cartId,
@@ -124,7 +126,7 @@ public function savePaymentInformation(
124126
}
125127

126128
/**
127-
* {@inheritDoc}
129+
* @inheritdoc
128130
*/
129131
public function getPaymentInformation($cartId)
130132
{

‎app/code/Magento/CheckoutAgreements/Model/ResourceModel/Agreement/Grid/Collection.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class Collection extends \Magento\CheckoutAgreements\Model\ResourceModel\Agreeme
1414
{
1515

1616
/**
17-
* {@inheritdoc}
17+
* @inheritdoc
1818
*/
1919
public function load($printQuery = false, $logQuery = false)
2020
{
@@ -30,6 +30,8 @@ public function load($printQuery = false, $logQuery = false)
3030
}
3131

3232
/**
33+
* Add stores to result
34+
*
3335
* @return void
3436
*/
3537
private function addStoresToResult()
@@ -56,6 +58,8 @@ private function addStoresToResult()
5658
}
5759

5860
/**
61+
* Get stores for agreements
62+
*
5963
* @return array
6064
*/
6165
private function getStoresForAgreements()

‎app/code/Magento/GiftMessage/Model/ItemRepository.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public function __construct(
7474
}
7575

7676
/**
77-
* {@inheritDoc}
77+
* @inheritdoc
7878
*/
7979
public function get($cartId, $itemId)
8080
{
@@ -103,7 +103,7 @@ public function get($cartId, $itemId)
103103
}
104104

105105
/**
106-
* {@inheritDoc}
106+
* @inheritdoc
107107
*/
108108
public function save($cartId, \Magento\GiftMessage\Api\Data\MessageInterface $giftMessage, $itemId)
109109
{

‎app/code/Magento/GiftMessage/Model/OrderItemRepository.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public function __construct(
8080
}
8181

8282
/**
83-
* {@inheritDoc}
83+
* @inheritdoc
8484
*/
8585
public function get($orderId, $orderItemId)
8686
{
@@ -111,7 +111,7 @@ public function get($orderId, $orderItemId)
111111
}
112112

113113
/**
114-
* {@inheritDoc}
114+
* @inheritdoc
115115
*/
116116
public function save($orderId, $orderItemId, \Magento\GiftMessage\Api\Data\MessageInterface $giftMessage)
117117
{

‎app/code/Magento/GiftMessage/Model/OrderRepository.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public function __construct(
7474
}
7575

7676
/**
77-
* {@inheritDoc}
77+
* @inheritdoc
7878
*/
7979
public function get($orderId)
8080
{
@@ -98,7 +98,7 @@ public function get($orderId)
9898
}
9999

100100
/**
101-
* {@inheritDoc}
101+
* @inheritdoc
102102
*/
103103
public function save($orderId, \Magento\GiftMessage\Api\Data\MessageInterface $giftMessage)
104104
{

‎app/code/Magento/Indexer/Console/Command/IndexerReindexCommand.php

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function __construct(
5858
}
5959

6060
/**
61-
* {@inheritdoc}
61+
* @inheritdoc
6262
*/
6363
protected function configure()
6464
{
@@ -70,7 +70,7 @@ protected function configure()
7070
}
7171

7272
/**
73-
* {@inheritdoc}
73+
* @inheritdoc
7474
*/
7575
protected function execute(InputInterface $input, OutputInterface $output)
7676
{
@@ -105,7 +105,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
105105
}
106106

107107
/**
108-
* {@inheritdoc} Returns the ordered list of specified indexers and related indexers.
108+
* @inheritdoc
109+
*
110+
* Returns the ordered list of specified indexers and related indexers.
109111
*/
110112
protected function getIndexers(InputInterface $input)
111113
{
@@ -272,6 +274,8 @@ private function getConfig()
272274
}
273275

274276
/**
277+
* Get indexer registry
278+
*
275279
* @return IndexerRegistry
276280
* @deprecated 100.2.0
277281
*/
@@ -284,6 +288,8 @@ private function getIndexerRegistry()
284288
}
285289

286290
/**
291+
* Get dependency info provider
292+
*
287293
* @return DependencyInfoProvider
288294
* @deprecated 100.2.0
289295
*/

‎app/code/Magento/Quote/Model/BillingAddressManagement.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
/**
1616
* Quote billing address write service object.
17-
*
1817
*/
1918
class BillingAddressManagement implements BillingAddressManagementInterface
2019
{
@@ -70,7 +69,7 @@ public function __construct(
7069
}
7170

7271
/**
73-
* {@inheritDoc}
72+
* @inheritdoc
7473
* @SuppressWarnings(PHPMD.NPathComplexity)
7574
*/
7675
public function assign($cartId, \Magento\Quote\Api\Data\AddressInterface $address, $useForShipping = false)
@@ -92,7 +91,7 @@ public function assign($cartId, \Magento\Quote\Api\Data\AddressInterface $addres
9291
}
9392

9493
/**
95-
* {@inheritDoc}
94+
* @inheritdoc
9695
*/
9796
public function get($cartId)
9897
{
@@ -101,6 +100,8 @@ public function get($cartId)
101100
}
102101

103102
/**
103+
* Get shipping address assignment
104+
*
104105
* @return \Magento\Quote\Model\ShippingAddressAssignment
105106
* @deprecated 100.2.0
106107
*/

0 commit comments

Comments
 (0)