Skip to content

Commit a76e3a3

Browse files
author
Tadhg Bowe
committed
import-export-improvements #82 : configurable variations - not a super attribute error message improvements - travis ci build code style fixes
1 parent 7f9f6db commit a76e3a3

File tree

1 file changed

+3
-6
lines changed
  • app/code/Magento/ConfigurableImportExport/Model/Import/Product/Type

1 file changed

+3
-6
lines changed

app/code/Magento/ConfigurableImportExport/Model/Import/Product/Type/Configurable.php

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -342,8 +342,7 @@ protected function _identifySuperAttributeError($superAttrCode, $rowNum)
342342

343343
if ($attributeRow['is_global'] !== '1') {
344344
$codeNotGlobal = true;
345-
}
346-
elseif ($attributeRow['type'] !== 'select') {
345+
} elseif ($attributeRow['type'] !== 'select') {
347346
$codeNotTypeSelect = true;
348347
}
349348

@@ -354,12 +353,10 @@ protected function _identifySuperAttributeError($superAttrCode, $rowNum)
354353
if ($codeExists == false) {
355354
$this->_entityModel->addRowError(self::ERROR_ATTRIBUTE_CODE_DOES_NOT_EXIST, $rowNum, $superAttrCode);
356355
$reasonFound = true;
357-
}
358-
elseif ($codeNotGlobal == true) {
356+
} elseif ($codeNotGlobal == true) {
359357
$this->_entityModel->addRowError(self::ERROR_ATTRIBUTE_CODE_NOT_GLOBAL_SCOPE, $rowNum, $superAttrCode);
360358
$reasonFound = true;
361-
}
362-
elseif ($codeNotTypeSelect == true) {
359+
} elseif ($codeNotTypeSelect == true) {
363360
$this->_entityModel->addRowError(self::ERROR_ATTRIBUTE_CODE_NOT_TYPE_SELECT, $rowNum, $superAttrCode);
364361
$reasonFound = true;
365362
}

0 commit comments

Comments
 (0)