Skip to content

Commit aad945c

Browse files
committed
Merge pull request #441 from magento-dragons/W1
[DRAGONS] BugFix
2 parents 6c3c600 + f591017 commit aad945c

File tree

5 files changed

+17
-6
lines changed

5 files changed

+17
-6
lines changed

app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/variations/steps/bulk.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,7 @@ define([
304304

305305
uploadInput.fileupload({
306306
dataType: 'json',
307+
dropZone: gallery,
307308
process: [{
308309
action: 'load',
309310
fileTypes: /^image\/(gif|jpeg|png)$/

app/code/Magento/Downloadable/Model/Product/Type.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ public function hasLinks($product)
178178
*/
179179
public function hasOptions($product)
180180
{
181-
return $product->getLinksPurchasedSeparately() || parent::hasOptions($product);
181+
return parent::hasOptions($product) || $this->hasLinks($product);
182182
}
183183

184184
/**

app/code/Magento/Search/view/frontend/templates/form.mini.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ $helper = $this->helper('Magento\Search\Helper\Data');
2323
<input id="search"
2424
data-mage-init='{"quickSearch":{
2525
"formSelector":"#search_mini_form",
26-
"url":"<?php /* @escapeNotVerified */ echo $block->getUrl('search/ajax/suggest'); ?>",
26+
"url":"<?php /* @escapeNotVerified */ echo $block->getUrl('search/ajax/suggest', ['_secure' => $block->getRequest()->isSecure()]); ?>",
2727
"destinationSelector":"#search_autocomplete"}
2828
}'
2929
type="text"

app/code/Magento/Theme/Block/Html/Topmenu.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ public function __construct(
4949
TreeFactory $treeFactory,
5050
array $data = []
5151
) {
52-
$this->setCacheLifetime(30 * 60);
5352
parent::__construct($context, $data);
5453
$this->_menu = $nodeFactory->create(
5554
[
@@ -60,6 +59,16 @@ public function __construct(
6059
);
6160
}
6261

62+
/**
63+
* Get block cache life time
64+
*
65+
* @return int
66+
*/
67+
protected function getCacheLifetime()
68+
{
69+
return parent::getCacheLifetime() ?: 3600;
70+
}
71+
6372
/**
6473
* Get top menu html
6574
*

dev/tests/integration/testsuite/Magento/GroupedProduct/Model/ResourceModel/Product/Type/Grouped/AssociatedProductsCollectionTest.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ public function testGetColumnValues()
3030
$resultData = $collection->getColumnValues('sku');
3131
$this->assertNotEmpty($resultData);
3232

33-
foreach (['simple-1', 'virtual-product'] as $skuExpected) {
34-
$this->assertTrue(in_array($skuExpected, $resultData));
35-
}
33+
$expected = ['virtual-product', 'simple-1'];
34+
sort($expected);
35+
sort($resultData);
36+
$this->assertEquals($expected, $resultData);
3637
}
3738
}

0 commit comments

Comments
 (0)