File tree Expand file tree Collapse file tree 3 files changed +9
-9
lines changed
app/code/Magento/AsynchronousOperations Expand file tree Collapse file tree 3 files changed +9
-9
lines changed Original file line number Diff line number Diff line change 10
10
use Magento \Framework \DataObject ;
11
11
12
12
/**
13
- * Class Operation
13
+ * Class Operation encapsulates methods for Operation Model Object
14
14
*/
15
15
class Operation extends DataObject implements OperationInterface
16
16
{
@@ -22,12 +22,12 @@ class Operation extends DataObject implements OperationInterface
22
22
/**
23
23
* Operation constructor.
24
24
*
25
- * @param array $data
26
25
* @param OperationStatusValidator $operationStatusValidator
26
+ * @param array $data
27
27
*/
28
28
public function __construct (
29
- array $ data = [] ,
30
- OperationStatusValidator $ operationStatusValidator
29
+ OperationStatusValidator $ operationStatusValidator ,
30
+ array $ data = []
31
31
) {
32
32
$ this ->operationStatusValidator = $ operationStatusValidator ;
33
33
parent ::__construct ($ data );
Original file line number Diff line number Diff line change @@ -32,7 +32,9 @@ public function __construct(OperationStatusPool $operationStatusPool)
32
32
/**
33
33
* Validate method
34
34
*
35
- * @param $status
35
+ * @param int $status
36
+ * @throws \InvalidArgumentException
37
+ * @return void
36
38
*/
37
39
public function validate ($ status )
38
40
{
@@ -41,7 +43,5 @@ public function validate($status)
41
43
if (!in_array ($ status , $ statuses )) {
42
44
throw new \InvalidArgumentException ('Invalid Operation Status. ' );
43
45
}
44
-
45
- return ;
46
46
}
47
47
}
Original file line number Diff line number Diff line change 12
12
use PHPUnit \Framework \TestCase ;
13
13
14
14
/**
15
- * Class OperationStatusValidatorTest
15
+ * Class OperationStatusValidatorTest implements logic for testing Operation::setStatus() method
16
16
*/
17
17
class OperationStatusValidatorTest extends TestCase
18
18
{
@@ -60,7 +60,7 @@ protected function setUp()
60
60
* @param string $expectedResult
61
61
* @dataProvider dataProviderForTestSetStatus
62
62
*/
63
- public function testSetStatus (
63
+ public function testSetStatus (
64
64
string $ status ,
65
65
array $ statusPool ,
66
66
string $ expectedResult
You can’t perform that action at this time.
0 commit comments