Skip to content

Commit b1e518c

Browse files
committed
Corrected Code Styles
1 parent 345ece3 commit b1e518c

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

app/code/Magento/AsynchronousOperations/Model/Operation.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
use Magento\Framework\DataObject;
1111

1212
/**
13-
* Class Operation
13+
* Class Operation encapsulates methods for Operation Model Object
1414
*/
1515
class Operation extends DataObject implements OperationInterface
1616
{
@@ -22,12 +22,12 @@ class Operation extends DataObject implements OperationInterface
2222
/**
2323
* Operation constructor.
2424
*
25-
* @param array $data
2625
* @param OperationStatusValidator $operationStatusValidator
26+
* @param array $data
2727
*/
2828
public function __construct(
29-
array $data = [],
30-
OperationStatusValidator $operationStatusValidator
29+
OperationStatusValidator $operationStatusValidator,
30+
array $data = []
3131
) {
3232
$this->operationStatusValidator = $operationStatusValidator;
3333
parent::__construct($data);

app/code/Magento/AsynchronousOperations/Model/OperationStatusValidator.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ public function __construct(OperationStatusPool $operationStatusPool)
3232
/**
3333
* Validate method
3434
*
35-
* @param $status
35+
* @param int $status
36+
* @throws \InvalidArgumentException
37+
* @return void
3638
*/
3739
public function validate($status)
3840
{
@@ -41,7 +43,5 @@ public function validate($status)
4143
if (!in_array($status, $statuses)) {
4244
throw new \InvalidArgumentException('Invalid Operation Status.');
4345
}
44-
45-
return;
4646
}
4747
}

app/code/Magento/AsynchronousOperations/Test/Unit/Model/OperationStatusValidatorTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
use PHPUnit\Framework\TestCase;
1313

1414
/**
15-
* Class OperationStatusValidatorTest
15+
* Class OperationStatusValidatorTest implements logic for testing Operation::setStatus() method
1616
*/
1717
class OperationStatusValidatorTest extends TestCase
1818
{
@@ -60,7 +60,7 @@ protected function setUp()
6060
* @param string $expectedResult
6161
* @dataProvider dataProviderForTestSetStatus
6262
*/
63-
public function testSetStatus (
63+
public function testSetStatus(
6464
string $status,
6565
array $statusPool,
6666
string $expectedResult

0 commit comments

Comments
 (0)