MAGETWO-80777: Delete CallExit function for After plugin logic execution 2.1-develop [BackPort] #11201

Oleksii Korshenko · web-flow · commit b427bcec628c · 2017-10-04T16:35:51.000-05:00
diff --git a/lib/internal/Magento/Framework/App/Response/Http/FileFactory.php b/lib/internal/Magento/Framework/App/Response/Http/FileFactory.php
@@ -99,19 +99,7 @@ public function create(
             if (!empty($content['rm'])) {
                 $dir->delete($file);
             }
-            $this->callExit();
         }
         return $this->_response;
     }
-
-    /**
-     * Call exit
-     *
-     * @return void
-     * @SuppressWarnings(PHPMD.ExitExpression)
-     */
-    protected function callExit()
-    {
-        exit(0);
-    }
 }
diff --git a/lib/internal/Magento/Framework/App/Test/Unit/Response/Http/FileFactoryTest.php b/lib/internal/Magento/Framework/App/Test/Unit/Response/Http/FileFactoryTest.php
@@ -244,7 +244,7 @@ private function getModelMock()
     {
         $modelMock = $this->getMock(
             'Magento\Framework\App\Response\Http\FileFactory',
-            ['callExit'],
+            null,
             [
                 'response' => $this->responseMock,
                 'filesystem' => $this->fileSystemMock,

Original file line number	Diff line number	Diff line change
`@@ -99,19 +99,7 @@ public function create(`
`99`	`99`	`if (!empty($content['rm'])) {`
`100`	`100`	`$dir->delete($file);`
`101`	`101`	`}`
`102`		`- $this->callExit();`
`103`	`102`	`}`
`104`	`103`	`return $this->_response;`
`105`	`104`	`}`
`106`		`-`
`107`		`- /**`
`108`		`- * Call exit`
`109`		`- *`
`110`		`- * @return void`
`111`		`- * @SuppressWarnings(PHPMD.ExitExpression)`
`112`		`- */`
`113`		`- protected function callExit()`
`114`		`- {`
`115`		`- exit(0);`
`116`		`- }`
`117`	`105`	`}`
Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ private function getModelMock()`
`244`	`244`	`{`
`245`	`245`	`$modelMock = $this->getMock(`
`246`	`246`	`'Magento\Framework\App\Response\Http\FileFactory',`
`247`		`- ['callExit'],`
	`247`	`+ null,`
`248`	`248`	`[`
`249`	`249`	`'response' => $this->responseMock,`
`250`	`250`	`'filesystem' => $this->fileSystemMock,`