Skip to content

Commit bbe0268

Browse files
author
Serhiy Shkolyarenko
committed
Merge pull request #58 from magento-folks/develop
[Folks] Sprint 60 - Service Layer: Refactoring of Checkout and related modules
2 parents c2cfbbf + 8d6b9c7 commit bbe0268

File tree

191 files changed

+6039
-9462
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

191 files changed

+6039
-9462
lines changed

app/code/Magento/Bundle/Model/Plugin/QuoteItem.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public function aroundConvert(
2323
\Magento\Quote\Model\Quote\Item\ToOrderItem $subject,
2424
Closure $proceed,
2525
\Magento\Quote\Model\Quote\Item\AbstractItem $item,
26-
$additional
26+
$additional = []
2727
) {
2828
/** @var $orderItem \Magento\Sales\Model\Order\Item */
2929
$orderItem = $proceed($item, $additional);

app/code/Magento/Catalog/view/frontend/templates/product/view/addtocart.phtml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@
4747
<script>
4848
require([
4949
"jquery",
50-
"mage/mage"
50+
"mage/mage",
51+
"Magento_Catalog/product/view/validation"
5152
], function($){
5253
$('#product_addtocart_form').mage('validation', {
5354
radioCheckboxClosest: '.nested'

app/code/Magento/Catalog/view/frontend/web/product/view/validation.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
$.widget("mage.validation", $.mage.validation, {
1919
options: {
20-
radioCheckboxClosest: 'ul',
20+
radioCheckboxClosest: 'ul, ol',
2121
errorPlacement: function (error, element) {
2222
if (element.attr('data-validate-message-box')) {
2323
var messageBox = $(element.attr('data-validate-message-box'));

app/code/Magento/Checkout/Controller/Onepage/SaveOrder.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ public function execute()
106106
$result['error'] = true;
107107
$result['error_messages'] = __('Something went wrong processing your order. Please try again later.');
108108
}
109-
$this->quoteRepository->save($this->getOnepage()->getQuote());
110109
/**
111110
* when there is redirect to third party, we don't want to save order yet.
112111
* we will save the order in return action.

app/code/Magento/Checkout/Service/V1/Address/Billing/ReadService.php

Lines changed: 0 additions & 58 deletions
This file was deleted.

app/code/Magento/Checkout/Service/V1/Address/Billing/ReadServiceInterface.php

Lines changed: 0 additions & 19 deletions
This file was deleted.

app/code/Magento/Checkout/Service/V1/Address/Billing/WriteService.php

Lines changed: 0 additions & 114 deletions
This file was deleted.

app/code/Magento/Checkout/Service/V1/Address/Billing/WriteServiceInterface.php

Lines changed: 0 additions & 23 deletions
This file was deleted.

app/code/Magento/Checkout/Service/V1/Address/Converter.php

Lines changed: 0 additions & 111 deletions
This file was deleted.

0 commit comments

Comments
 (0)