magento-engcom/import-export-improvements#101: Change test case to use two different products with the same URL key to prevent 'SKU already exists' error.

Author: carstenpfeifer

dev/tests/functional/tests/app/Magento/CatalogUrlRewrite/Test/TestCase/CreateDuplicateUrlProductEntity.php

@@ -68,6 +68,7 @@ public function __prepare(Category $category)
      * Run create product simple entity test.
      *
      * @param CatalogProductSimple $product
+     * @param CatalogProductSimple $product2
      * @param Category $category
      * @param CatalogProductIndex $productGrid
      * @param CatalogProductNew $newProductPage
@@ -77,6 +78,7 @@ public function __prepare(Category $category)
      */
     public function testCreate(
         CatalogProductSimple $product,
+        CatalogProductSimple $product2,
         Category $category,
         CatalogProductIndex $productGrid,
         CatalogProductNew $newProductPage,
@@ -92,13 +94,15 @@ public function testCreate(
             ['configData' => $this->configData, 'flushCache' => $this->flushCache]
         )->run();
 
-        for ($index = 0; $index < 2; $index++) {
-            // Duplicate product
-            $productGrid->open();
-            $productGrid->getGridPageActionBlock()->addProduct('simple');
-            $newProductPage->getProductForm()->fill($product, null, $category);
-            $newProductPage->getFormPageActions()->save();
-        }
+        $productGrid->open();
+        $productGrid->getGridPageActionBlock()->addProduct('simple');
+        $newProductPage->getProductForm()->fill($product, null, $category);
+        $newProductPage->getFormPageActions()->save();
+
+        $productGrid->open();
+        $productGrid->getGridPageActionBlock()->addProduct('simple');
+        $newProductPage->getProductForm()->fill($product2, null, $category);
+        $newProductPage->getFormPageActions()->save();
 
         return ['product' => $product];
     }

dev/tests/functional/tests/app/Magento/CatalogUrlRewrite/Test/TestCase/CreateDuplicateUrlProductEntity.xml

@@ -8,13 +8,19 @@
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../vendor/magento/mtf/etc/variations.xsd">
     <testCase name="Magento\CatalogUrlRewrite\Test\TestCase\CreateDuplicateUrlProductEntity" summary="Create Simple Product" ticketId="MAGETWO-69427">
         <variation name="CreateDuplicateUrlProductEntityTestVariation1" summary="Create Duplicate Url Product">
-            <data name="tag" xsi:type="string">test_type:acceptance_test, test_type:extended_acceptance_test, severity:S1, mftf_migrated:yes</data>
-            <data name="product/data/url_key" xsi:type="string">simple-product-%isolation%</data>
+            <data name="tag" xsi:type="string">test_type:acceptance_test, test_type:extended_acceptance_test, severity:S1</data>
+            <data name="product/data/url_key" xsi:type="string">simple-product-samekey</data>
             <data name="product/data/name" xsi:type="string">Simple Product %isolation%</data>
             <data name="product/data/sku" xsi:type="string">simple_sku_%isolation%</data>
             <data name="product/data/price/value" xsi:type="string">10000</data>
             <data name="product/data/weight" xsi:type="string">50</data>
             <data name="product/data/quantity_and_stock_status/qty" xsi:type="string">657</data>
+            <data name="product2/data/url_key" xsi:type="string">simple-product-samekey</data>
+            <data name="product2/data/name" xsi:type="string">Simple Product %isolation%</data>
+            <data name="product2/data/sku" xsi:type="string">simple_sku_%isolation%</data>
+            <data name="product2/data/price/value" xsi:type="string">10000</data>
+            <data name="product2/data/weight" xsi:type="string">50</data>
+            <data name="product2/data/quantity_and_stock_status/qty" xsi:type="string">657</data>
             <constraint name="Magento\CatalogUrlRewrite\Test\Constraint\AssertProductUrlDuplicateErrorMessage" />
         </variation>
     </testCase>