🔃 [EngCom] Public Pull Requests - 2.1-develop

Accepted Public Pull Requests:
 - #16667: [Backport] Improve retrieval of first array element (by @mageprince)
 - #16671: [Backport] Removed unused class from forms less file. (by @mageprince)
 - #16665: [Backport] 7399-clickableOverlay-less-fix - added pointer-events rule to .modal-� (by @mageprince)
 - #16643: [Backport] Variable as a method parameter might be overridden by the loop (by @lfluvisotto)
 - #16601: [2.1-develop][BackPort] Fixed backwards incompatible change to Transport variable event parameters (by @gwharton)
 - #16634: [Backport] Updated SynonymGroup.xml (by @sanganinamrata)
 - #16493: [Backport] Prevent layout cache corruption in edge case (by @gelanivishal)


Fixed GitHub Issues:
 - #7399: Modal UI: clickableOverlay option doesn't work (reported by @thdoan) has been fixed in #16665 by @mageprince in 2.1-develop branch
   Related commits:
     1. 4c53caf

 - #10210: Transport variable can not be altered in email_invoice_set_template_vars_before Event (reported by @diybook) has been fixed in #16601 by @gwharton in 2.1-develop branch
   Related commits:
     1. 390fc2f

Author: Stanislav Idolov

app/code/Magento/Bundle/Model/Product/Type.php

@@ -497,12 +497,12 @@ public function updateQtyOption($options, \Magento\Framework\DataObject $option,
 
         foreach ($selections as $selection) {
             if ($selection->getProductId() == $optionProduct->getId()) {
-                foreach ($options as &$option) {
-                    if ($option->getCode() == 'selection_qty_' . $selection->getSelectionId()) {
+                foreach ($options as $quoteItemOption) {
+                    if ($quoteItemOption->getCode() == 'selection_qty_' . $selection->getSelectionId()) {
                         if ($optionUpdateFlag) {
-                            $option->setValue(intval($option->getValue()));
+                            $quoteItemOption->setValue(intval($quoteItemOption->getValue()));
                         } else {
-                            $option->setValue($value);
+                            $quoteItemOption->setValue($value);
                         }
                     }
                 }

app/code/Magento/Rule/Model/Action/AbstractAction.php

@@ -46,13 +46,16 @@ public function __construct(
 
         $this->loadAttributeOptions()->loadOperatorOptions()->loadValueOptions();
 
-        foreach (array_keys($this->getAttributeOption()) as $attr) {
-            $this->setAttribute($attr);
-            break;
+        $attributes = $this->getAttributeOption();
+        if ($attributes) {
+            reset($attributes);
+            $this->setAttribute(key($attributes));
         }
-        foreach (array_keys($this->getOperatorOption()) as $operator) {
-            $this->setOperator($operator);
-            break;
+
+        $operators = $this->getOperatorOption();
+        if ($operators) {
+            reset($operators);
+            $this->setOperator(key($operators));
         }
     }
 

app/code/Magento/Rule/Model/Condition/Combine.php

@@ -42,14 +42,13 @@ public function __construct(Context $context, array $data = [])
         $this->loadAggregatorOptions();
         $options = $this->getAggregatorOptions();
         if ($options) {
-            foreach (array_keys($options) as $aggregator) {
-                $this->setAggregator($aggregator);
-                break;
-            }
+            reset($options);
+            $this->setAggregator(key($options));
         }
     }
 
     /* start aggregator methods */
+
     /**
      * @return $this
      */
@@ -85,9 +84,10 @@ public function getAggregatorName()
     public function getAggregatorElement()
     {
         if ($this->getAggregator() === null) {
-            foreach (array_keys($this->getAggregatorOption()) as $key) {
-                $this->setAggregator($key);
-                break;
+            $options = $this->getAggregatorOption();
+            if ($options) {
+                reset($options);
+                $this->setAggregator(key($options));
             }
         }
         return $this->getForm()->addField(

app/code/Magento/Sales/Model/Order/Email/Sender/OrderSender.php

@@ -135,7 +135,7 @@ protected function prepareTemplate(Order $order)
          */
         $this->eventManager->dispatch(
             'email_order_set_template_vars_before',
-            ['sender' => $this, 'transport' => $transportObject->getData(), 'transportObject' => $transportObject]
+            ['sender' => $this, 'transport' => $transportObject, 'transportObject' => $transportObject]
         );
 
         $this->templateContainer->setTemplateVars($transportObject->getData());

app/design/frontend/Magento/blank/web/css/source/components/_modals_extend.less

@@ -64,6 +64,8 @@
     }
 
     .modal-popup {
+        pointer-events: none;
+
         .modal-title {
             .lib-css(border-bottom, @modal-title__border);
             .lib-css(font-weight, @font-weight__light);

app/design/frontend/Magento/luma/web/css/source/components/_modals_extend.less

@@ -64,6 +64,8 @@
     }
 
     .modal-popup {
+        pointer-events: none;
+
         .modal-title {
             .lib-css(border-bottom, @modal-title__border);
             .lib-css(font-weight, @font-weight__light);

dev/tests/functional/tests/app/Magento/Search/Test/Fixture/SynonymGroup.xml

@@ -13,7 +13,7 @@
              collection="Magento\Search\Model\ResourceModel\Block\Grid\Collection"
              handler_interface="Magento\Search\Test\Handler\SynonymGroup\SynonymGroupInterface"
              repository_class="Magento\Search\Test\Repository\SynonymGroup" class="Magento\Search\Test\Fixture\SynonymGroup">
-        <field name="group_id" is_required="1 "/>
+        <field name="group_id" is_required="1"/>
         <field name="synonyms" is_required="0" />
         <field name="scope_id" is_required="0" source="Magento\Search\Test\Fixture\SynonymGroup\ScopeId" />
         <field name="mergeOnConflict" is_required="0" />

lib/internal/Magento/Framework/View/Model/Layout/Merge.php

@@ -427,6 +427,9 @@ public function load($handles = [])
         if ($result) {
             $this->addUpdate($result);
             $this->pageLayout = $this->_loadCache($cacheIdPageLayout);
+            foreach ($this->getHandles() as $handle) {
+                $this->allHandles[$handle] = $this->handleProcessed;
+            }
             return $this;
         }
 

lib/web/css/source/lib/_forms.less

@@ -465,11 +465,9 @@
     .lib-css(margin, @_margin);
     .lib-css(padding, @_padding);
     letter-spacing: -.31em;
-    //word-spacing: -.43em;
 
     > * {
         letter-spacing: normal;
-        //word-spacing: normal;
     }
 
     > .legend {