MAGETWO-47439: [Github] i18n:collect-phrases -m can't find many important magento phrases #2630

- added support of $t("some text")
- added support of xml attributes translation

Author: Oleksii Korshenko

setup/src/Magento/Setup/Module/I18n/Dictionary/Phrase.php

@@ -270,8 +270,8 @@ private function getCompiledString($string)
     {
         $encloseQuote = $this->getQuote() == Phrase::QUOTE_DOUBLE ? Phrase::QUOTE_DOUBLE : Phrase::QUOTE_SINGLE;
         //find all occurrences of ' and ", with no \ before it.
-        preg_match_all('/(?<!\\\\)[\'"]/', $string, $matches);
-        if (count($matches[0]) % 2 !== 0) {
+        preg_match_all('/[^\\\\]' . $encloseQuote . '/', $string, $matches);
+        if (count($matches[0])) {
             $string = addslashes($string);
         }
         $evalString = 'return ' . $encloseQuote . $string . $encloseQuote . ';';

setup/src/Magento/Setup/Module/I18n/Parser/Adapter/Js.php

@@ -28,6 +28,14 @@ protected function _parse()
                     $this->_addPhrase($quote . $results[$i][2] . $quote, $lineNumber);
                 }
             }
+
+            preg_match_all('/\\$t\(\s*([\'"])(.*?[^\\\])\1.*?[),]/', $fileRow, $results, PREG_SET_ORDER);
+            for ($i = 0; $i < count($results); $i++) {
+                if (isset($results[$i][2])) {
+                    $quote = $results[$i][1];
+                    $this->_addPhrase($quote . $results[$i][2] . $quote, $lineNumber);
+                }
+            }
         }
         fclose($fileHandle);
     }

setup/src/Magento/Setup/Module/I18n/Parser/Adapter/Xml.php

@@ -33,6 +33,13 @@ protected function _parse()
                     if ($phrase) {
                         $this->_addPhrase($phrase);
                     }
+                    $elementAttributes = $element->attributes();
+                    if (isset($elementAttributes[$value])) {
+                        $phrase = (string)$elementAttributes[$value];
+                        if ($phrase) {
+                            $this->_addPhrase($phrase);
+                        }
+                    }
                 }
             }
         }