ENGCOM-3264: Remove unnecessary conditional statements #18792

Stanislav Idolov · web-flow · commit fce8182e7d4e · 2018-10-26T08:59:00.000+03:00
diff --git a/app/code/Magento/User/Controller/Adminhtml/User/Role/SaveRole.php b/app/code/Magento/User/Controller/Adminhtml/User/Role/SaveRole.php
@@ -59,9 +59,8 @@ private function getSecurityCookie()
     {
         if (!($this->securityCookie instanceof SecurityCookie)) {
             return \Magento\Framework\App\ObjectManager::getInstance()->get(SecurityCookie::class);
-        } else {
-            return $this->securityCookie;
         }
+        return $this->securityCookie;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -59,9 +59,8 @@ private function getSecurityCookie()`
`59`	`59`	`{`
`60`	`60`	`if (!($this->securityCookie instanceof SecurityCookie)) {`
`61`	`61`	`return \Magento\Framework\App\ObjectManager::getInstance()->get(SecurityCookie::class);`
`62`		`- } else {`
`63`		`- return $this->securityCookie;`
`64`	`62`	`}`
	`63`	`+ return $this->securityCookie;`
`65`	`64`	`}`
`66`	`65`
`67`	`66`	`/**`