Skip to content

Gallery Full Page Image Gallery Wont Close on Mobile #12185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
p3kyle opened this issue Nov 10, 2017 · 13 comments
Closed

Gallery Full Page Image Gallery Wont Close on Mobile #12185

p3kyle opened this issue Nov 10, 2017 · 13 comments
Labels
Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@p3kyle
Copy link

p3kyle commented Nov 10, 2017

Preconditions

  1. Magento 2.2.1 (also on Magento 2.2) on magemojo hosting

Steps to reproduce

  1. Go on any new Android or IOS device, go to a product page, open the image gallery of the item. Try to click the upper right hand X and the gallery doesnt close. You have to hit the back button on the browser to get out of it but when you do that, it takes you back to the product grid page. It has been tested on iphone 6, 6s, pixel 2 xl, and galaxy 7.

Expected result

  1. It should close the gallery and you should remain on the product page

Actual result

  1. Nothing happens when you click the x button
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Nov 10, 2017
@magento-engcom-team
Copy link
Contributor

@p3kyle, thank you for your report.
We were not able to reproduce this issue by following the steps you provided. If you'd like to update it, please reopen the issue.
We tested the issue on 2.3.0-dev, 2.1.10, 2.2.1

@magento-engcom-team magento-engcom-team added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Nov 13, 2017
@NaciAkce
Copy link

@magento-engcom-team
me too on Iphone 7. Maybe you have to test it on real devices

@jmonschke
Copy link

I was able to reproduce this issue when using the iOS simulator, but not while using the Chrome DevTools emulating the mobile browsers.

@alexcrz
Copy link

alexcrz commented Dec 27, 2017

I'm having the same issue, on a Magento 2.2.1, can't close the product gallery on iPhone, but works fine on Windows Mobile or Android, any solution?

@s2892
Copy link

s2892 commented Dec 28, 2017

The same
google chrome dev iOS is working
iPhone 7 / iPad Air - not working (Safari and Chrome)

Any Solution ?

@vipinroy
Copy link

vipinroy commented Dec 28, 2017

The same issue for me also in Magento 2.2.1.
The gallery will close when you press Escape button.
But it will not close when you click the close button on the top right.
The issue exists in ipads only.

@The0h
Copy link

The0h commented Dec 29, 2017

Same issue for me using Magento 2.2.2.
Problem occurs on iPhone 5s/6/6s/7 and on iPad mini.

Any solutions yet?

@iparmentier
Copy link

Same issue in Magento 2.2.2
Test with iPhone 6 device.
You can't reproduce this on a web browser.

@s2892
Copy link

s2892 commented Jan 30, 2018

any progress ?

@robertkent
Copy link

This is definitely a problem on 2.2.2 - on desktop in mobile mode is fine - but on simulators and real devices you can't tap the cross to close full screen gallery - users must refresh the page.

@silversil
Copy link

I have same issue, how it is possible that it isn’t fixed?!?

@wontroba666
Copy link

same on 2.2.6

@farazWebDev
Copy link

farazWebDev commented Oct 17, 2018

Fixed working partially only.
Still facing same issue, on v2.2.5 and v2.2.6 for:
Safari browser working but iOS app not working (web view).
Android Phone - Chrome browser working but default browser not working.

---Update---
Strange case, removing iOS check from method stubEvent ( \lib\web\fotorama\fotorama.js#L1220 ), allowing it to work with Android mobile (tested on HTC, SAMSUNG, XIAOMI) default browser, Mobile Mozilla browser and iOS App (tested on iPAD and iPHONE 6S - in web view):

function stubEvent($el, eventType) {
	var isIOS = /ip(ad|hone|od)/i.test(window.navigator.userAgent);

	if (eventType === 'touchend') {
	//if (isIOS && eventType === 'touchend') {
		$el.on('touchend', function(e){
			$DOCUMENT.trigger('mouseup', e);
		})
	}
	$el.on(eventType, function (e) {
		stopEvent(e, true);

		return false;
	});
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests